Skip to content

🐸 Rybbit - open-source and privacy-friendly alternative to Google Analytics that is 10x more intuitive.

Add rel attribute to external link (#834)

Ryan Wang5491480d3082
diff --git a/client/src/app/[site]/components/shared/StandardSection/Row.tsx b/client/src/app/[site]/components/shared/StandardSection/Row.tsx
index c537e87fb..e1d2c0614 100644
--- a/client/src/app/[site]/components/shared/StandardSection/Row.tsx
+++ b/client/src/app/[site]/components/shared/StandardSection/Row.tsx
@@ -67,7 +67,7 @@ const RowItem = ({
{leftContent}
<span className="truncate">{getLabel(item)}</span>
{getLink && (
- <a href={getLink(item)} target="_blank" onClick={e => e.stopPropagation()} className="shrink-0">
+ <a href={getLink(item)} rel="noopener noreferrer" target="_blank" onClick={e => e.stopPropagation()} className="shrink-0">
<SquareArrowOutUpRight
className="ml-0.5 w-3.5 h-3.5 text-neutral-600 hover:text-neutral-900 dark:text-neutral-300 dark:hover:text-neutral-100"
strokeWidth={3}
diff --git a/client/src/app/[site]/components/shared/StandardSection/StandardSectionDialog.tsx b/client/src/app/[site]/components/shared/StandardSection/StandardSectionDialog.tsx
index 215afa16c..798fb6ad3 100644
--- a/client/src/app/[site]/components/shared/StandardSection/StandardSectionDialog.tsx
+++ b/client/src/app/[site]/components/shared/StandardSection/StandardSectionDialog.tsx
@@ -98,7 +98,7 @@ export function StandardSectionDialog({
<div className="flex flex-row gap-1 items-center text-left">
{getLabel(row.original)}
{getLink && (
- <a href={getLink(row.original)} target="_blank" onClick={e => e.stopPropagation()}>
+ <a rel="noopener noreferrer" href={getLink(row.original)} target="_blank" onClick={e => e.stopPropagation()}>
<SquareArrowOutUpRight
className="ml-0.5 w-3.5 h-3.5 text-neutral-600 hover:text-neutral-900 dark:text-neutral-300 dark:hover:text-neutral-100"
strokeWidth={3}