🐸 Rybbit - open-source and privacy-friendly alternative to Google Analytics that is 10x more intuitive.
refactor(replay): remove unused gzip batch decoding (#1266)
Goldflag6bc9e19df013
diff --git a/server/src/services/storage/r2StorageService.test.ts b/server/src/services/storage/r2StorageService.test.tsindex b3cd04f25..756ba591e 100644--- a/server/src/services/storage/r2StorageService.test.ts+++ b/server/src/services/storage/r2StorageService.test.ts@@ -1,4 +1,3 @@-import { gzipSync } from "node:zlib";import { Readable } from "node:stream";import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";@@ -257,15 +256,6 @@ describe("r2Storage.getBatch", () => {expect(mocks.decompress).toHaveBeenCalledWith(compressed);});- it("uses gzip decompression for legacy .gz objects", async () => {- const events = [{ type: "pageview", pathname: "/legacy" }];- mocks.send.mockResolvedValue({ Body: Readable.from([gzipSync(JSON.stringify(events))]) });- const storage = await loadStorage();-- await expect(storage.getBatch("1/session/legacy.json.gz")).resolves.toEqual(events);- expect(mocks.decompress).not.toHaveBeenCalled();- });-it("defaults unknown extensions to zstd decompression", async () => {const compressed = Buffer.from('zstd:[{"type":"custom_event"}]');mocks.send.mockResolvedValue({ Body: Readable.from([compressed]) });diff --git a/server/src/services/storage/r2StorageService.ts b/server/src/services/storage/r2StorageService.tsindex 87bf07df2..921a0dc9e 100644--- a/server/src/services/storage/r2StorageService.ts+++ b/server/src/services/storage/r2StorageService.ts@@ -7,7 +7,6 @@ import {} from "@aws-sdk/client-s3";import { NodeHttpHandler } from "@smithy/node-http-handler";import { Readable } from "stream";-import { gunzipSync } from "zlib";import { compress as zstdCompress, decompress as zstdDecompress } from "@mongodb-js/zstd";import { IS_CLOUD } from "../../lib/const.js";import { createServiceLogger } from "../../lib/logger/logger.js";@@ -150,18 +149,8 @@ class R2StorageService {}}- // Try to decompress based on file extension- let decompressed: Buffer;-try {- if (key.endsWith(".zst")) {- decompressed = await zstdDecompress(buffer);- } else if (key.endsWith(".gz")) {- decompressed = gunzipSync(buffer);- } else {- // Assume zstd for unknown extensions- decompressed = await zstdDecompress(buffer);- }+ const decompressed = await zstdDecompress(buffer);return JSON.parse(decompressed.toString());} catch (decompressionError: any) {// If decompression fails and we haven't tried JSON yet, try it now