Skip to content

🐸 Rybbit - open-source and privacy-friendly alternative to Google Analytics that is 10x more intuitive.

Remove access checks from GSC data retrieval functions

Bill Yanga9a5b73f362b
diff --git a/server/src/api/gsc/getData.ts b/server/src/api/gsc/getData.ts
index 49c77f56c..cb50c5027 100644
--- a/server/src/api/gsc/getData.ts
+++ b/server/src/api/gsc/getData.ts
@@ -29,12 +29,6 @@ export async function getGSCData(req: FastifyRequest<GetGSCDataRequest>, res: Fa
return res.status(400).send({ error: "Missing dimension parameter" });
}
- // Check if user has access to this site
- const hasAccess = await getUserHasAccessToSite(req, siteId);
- if (!hasAccess) {
- return res.status(403).send({ error: "Access denied" });
- }
-
// Get connection
const [connection] = await db.select().from(gscConnections).where(eq(gscConnections.siteId, siteId));
diff --git a/server/src/api/gsc/status.ts b/server/src/api/gsc/status.ts
index 5bc5b353a..b3745a226 100644
--- a/server/src/api/gsc/status.ts
+++ b/server/src/api/gsc/status.ts
@@ -1,10 +1,9 @@
-import { FastifyReply, FastifyRequest } from "fastify";
-import { GetGSCStatusRequest } from "./types.js";
-import { gscConnections } from "../../db/postgres/schema.js";
import { eq } from "drizzle-orm";
-import { getUserHasAccessToSite } from "../../lib/auth-utils.js";
+import { FastifyReply, FastifyRequest } from "fastify";
import { db } from "../../db/postgres/postgres.js";
+import { gscConnections } from "../../db/postgres/schema.js";
import { logger } from "../../lib/logger/logger.js";
+import { GetGSCStatusRequest } from "./types.js";
/**
* Checks if a site has an active GSC connection
@@ -18,12 +17,6 @@ export async function getGSCStatus(req: FastifyRequest<GetGSCStatusRequest>, res
return res.status(400).send({ error: "Invalid site ID" });
}
- // Check if user has access to this site
- const hasAccess = await getUserHasAccessToSite(req, siteId);
- if (!hasAccess) {
- return res.status(403).send({ error: "Access denied" });
- }
-
const [connection] = await db.select().from(gscConnections).where(eq(gscConnections.siteId, siteId));
if (!connection) {