Skip to content

🐸 Rybbit - open-source and privacy-friendly alternative to Google Analytics that is 10x more intuitive.

fix(tests): update UTM campaign query to use argMinIf for better filtering in funnel and experiment result tests

Bill Yangc8465b1fdf09
diff --git a/server/src/api/analytics/funnels/funnelQueries.test.ts b/server/src/api/analytics/funnels/funnelQueries.test.ts
index 9a22b624d..3c5a89147 100644
--- a/server/src/api/analytics/funnels/funnelQueries.test.ts
+++ b/server/src/api/analytics/funnels/funnelQueries.test.ts
@@ -37,7 +37,7 @@ describe("funnel queries with global session filters", () => {
const sessionActions = getSessionActions(sql);
expect(sql).toContain("FilteredSessions AS");
- expect(sql).toContain("argMin(url_parameters, timestamp)['utm_campaign'] AS utm_campaign");
+ expect(sql).toContain("argMinIf(url_parameters['utm_campaign'], timestamp, url_parameters['utm_campaign'] != '') AS utm_campaign");
expect(sql).toContain("WHERE 1 = 1 AND utm_campaign = 'launch'");
expect(sessionActions).toContain("INNER JOIN FilteredSessions USING (session_id)");
expect(sessionActions).not.toContain("url_parameters['utm_campaign'] = 'launch'");
diff --git a/server/src/api/experiments/getExperimentResults.test.ts b/server/src/api/experiments/getExperimentResults.test.ts
index a84e994dc..be512a87c 100644
--- a/server/src/api/experiments/getExperimentResults.test.ts
+++ b/server/src/api/experiments/getExperimentResults.test.ts
@@ -31,7 +31,7 @@ describe("experiment result queries", () => {
const { exposureQuery } = buildQueries();
expect(exposureQuery).toContain("FilteredSessions AS");
- expect(exposureQuery).toContain("argMin(url_parameters, timestamp)['utm_campaign'] AS utm_campaign");
+ expect(exposureQuery).toContain("argMinIf(url_parameters['utm_campaign'], timestamp, url_parameters['utm_campaign'] != '') AS utm_campaign");
expect(exposureQuery).toContain("WHERE 1 = 1 AND utm_campaign = 'recipe_book_2026'");
expect(exposureQuery.match(/INNER JOIN FilteredSessions USING \(session_id\)/g)).toHaveLength(2);
expect(exposureQuery).toContain("event_name = 'feature_flag_exposure'");