Skip to content

🐸 Rybbit - open-source and privacy-friendly alternative to Google Analytics that is 10x more intuitive.

fix: invalidate site access cache after creation (#1142)

Goldflagf307375a47ec
diff --git a/server/src/api/sites/addSite.test.ts b/server/src/api/sites/addSite.test.ts
index a3fec075b..726625e50 100644
--- a/server/src/api/sites/addSite.test.ts
+++ b/server/src/api/sites/addSite.test.ts
@@ -8,6 +8,7 @@ const state = vi.hoisted(() => ({
const mocks = vi.hoisted(() => ({
getSubscriptionInner: vi.fn(),
+ invalidateSitesAccessCache: vi.fn(),
}));
vi.mock("../../db/postgres/postgres.js", () => ({
@@ -42,6 +43,10 @@ vi.mock("../stripe/getSubscription.js", () => ({
getSubscriptionInner: mocks.getSubscriptionInner,
}));
+vi.mock("../../lib/auth-utils.js", () => ({
+ invalidateSitesAccessCache: mocks.invalidateSitesAccessCache,
+}));
+
import { addSite } from "./addSite.js";
function replyStub() {
@@ -80,6 +85,18 @@ beforeEach(() => {
mocks.getSubscriptionInner.mockResolvedValue(subscription());
});
+describe("addSite — access cache invalidation", () => {
+ it("invalidates the creator's cached site access after creating a site", async () => {
+ const reply = replyStub();
+
+ await addSite(makeRequest({}), reply);
+
+ expect(reply.statusCode).toBe(201);
+ expect(mocks.invalidateSitesAccessCache).toHaveBeenCalledOnce();
+ expect(mocks.invalidateSitesAccessCache).toHaveBeenCalledWith("u_1");
+ });
+});
+
describe("addSite — cloud pro-feature gating (session replay)", () => {
it("rejects session replay on a non-pro plan and inserts nothing", async () => {
mocks.getSubscriptionInner.mockResolvedValue(subscription({ planName: "basic-100k", status: "active" }));
diff --git a/server/src/api/sites/addSite.ts b/server/src/api/sites/addSite.ts
index 64f46b876..f1c503c3d 100644
--- a/server/src/api/sites/addSite.ts
+++ b/server/src/api/sites/addSite.ts
@@ -1,4 +1,5 @@
import { FastifyReply, FastifyRequest } from "fastify";
+import { invalidateSitesAccessCache } from "../../lib/auth-utils.js";
import {
type CreateSiteInput,
SiteLifecycleError,
@@ -21,6 +22,10 @@ export async function addSite(
createdBy: request.user?.id,
});
+ if (request.user?.id) {
+ invalidateSitesAccessCache(request.user.id);
+ }
+
return reply.status(201).send(newSite);
} catch (error) {
if (error instanceof SiteLifecycleError) {