Skip to content

🐸 Rybbit - open-source and privacy-friendly alternative to Google Analytics that is 10x more intuitive.

Update Filters component with new parameter labels and options

Bill Yangf3630b6158fa
diff --git a/client/src/app/[site]/components/SubHeader/Filters/Filters.tsx b/client/src/app/[site]/components/SubHeader/Filters/Filters.tsx
index 8a24de7ae..a13d11b8d 100644
--- a/client/src/app/[site]/components/SubHeader/Filters/Filters.tsx
+++ b/client/src/app/[site]/components/SubHeader/Filters/Filters.tsx
@@ -18,7 +18,7 @@ function getParameterNameLabel(parameter: FilterParameter) {
case "device_type":
return "Device Type";
case "operating_system":
- return "Operating System";
+ return "OS";
case "browser":
return "Browser";
case "referrer":
@@ -26,9 +26,9 @@ function getParameterNameLabel(parameter: FilterParameter) {
case "pathname":
return "Path";
case "page_title":
- return "Page Title";
+ return "Title";
case "querystring":
- return "Query String";
+ return "Query";
case "language":
return "Language";
case "city":
@@ -37,6 +37,12 @@ function getParameterNameLabel(parameter: FilterParameter) {
return "Region";
case "iso_3166_2":
return "Region";
+ case "entry_page":
+ return "Entry Page";
+ case "exit_page":
+ return "Exit Page";
+ case "dimensions":
+ return "Dimension";
default:
return parameter;
}
diff --git a/client/src/app/[site]/components/SubHeader/Filters/NewFilterButton.tsx b/client/src/app/[site]/components/SubHeader/Filters/NewFilterButton.tsx
index 6f9bf03f6..9cc8bd77a 100644
--- a/client/src/app/[site]/components/SubHeader/Filters/NewFilterButton.tsx
+++ b/client/src/app/[site]/components/SubHeader/Filters/NewFilterButton.tsx
@@ -38,10 +38,10 @@ const FilterOptions: { label: string; value: FilterParameter }[] = [
label: "Region",
value: "iso_3166_2",
},
- {
- label: "City",
- value: "city",
- },
+ // {
+ // label: "City",
+ // value: "city",
+ // },
{
label: "Device Type",
value: "device_type",
@@ -58,6 +58,18 @@ const FilterOptions: { label: string; value: FilterParameter }[] = [
label: "Language",
value: "language",
},
+ {
+ label: "Entry Page",
+ value: "entry_page",
+ },
+ {
+ label: "Exit Page",
+ value: "exit_page",
+ },
+ {
+ label: "Screen Dimensions",
+ value: "dimensions",
+ },
];
export function NewFilterButton() {
@@ -87,6 +99,9 @@ export function NewFilterButton() {
selectedFilter?.value === "country" ||
selectedFilter?.value === "region" ||
selectedFilter?.value === "city" ||
+ selectedFilter?.value === "iso_3166_2" ||
+ selectedFilter?.value === "entry_page" ||
+ selectedFilter?.value === "exit_page" ||
selectedFilter?.value === "querystring"
) {
return [