Skip to content

🐸 Rybbit - open-source and privacy-friendly alternative to Google Analytics that is 10x more intuitive.

Refactor SiteSettings component to use Dialog for improved UI consistency

Bill Yangf5e251add454
diff --git a/client/src/components/SiteSettings/SiteSettings.tsx b/client/src/components/SiteSettings/SiteSettings.tsx
index c2efb2fa1..2bbdad0ba 100644
--- a/client/src/components/SiteSettings/SiteSettings.tsx
+++ b/client/src/components/SiteSettings/SiteSettings.tsx
@@ -5,21 +5,23 @@ import { useState } from "react";
import { Button } from "@/components/ui/button";
import {
- ResponsiveDialog,
- ResponsiveDialogContent,
- ResponsiveDialogDescription,
- ResponsiveDialogHeader,
- ResponsiveDialogTitle,
- ResponsiveDialogTrigger,
-} from "@/components/ui/responsive-dialog";
+ Dialog,
+ DialogClose,
+ DialogContent,
+ DialogDescription,
+ DialogFooter,
+ DialogHeader,
+ DialogTitle,
+ DialogTrigger,
+} from "@/components/ui/dialog";
import { Tabs, TabsContent, TabsList, TabsTrigger } from "@/components/ui/tabs";
-import { useUserOrganizations } from "@/api/admin/hooks/useOrganizations";
-import { SiteResponse } from "@/api/admin/endpoints";
-import { useGetSite } from "@/api/admin/hooks/useSites";
-import { ImportManager } from "./ImportManager";
import { ScriptBuilder } from "./ScriptBuilder";
import { SiteConfiguration } from "./SiteConfiguration";
+import { ImportManager } from "./ImportManager";
+import { useGetSite } from "../../api/admin/hooks/useSites";
+import { useUserOrganizations } from "../../api/admin/hooks/useOrganizations";
+import { SiteResponse } from "../../api/admin/endpoints";
export function SiteSettings({ siteId, trigger }: { siteId: number; trigger?: React.ReactNode }) {
const { data: siteMetadata, isLoading, error } = useGetSite(siteId);
@@ -43,19 +45,19 @@ function SiteSettingsInner({ siteMetadata, trigger }: { siteMetadata: SiteRespon
}
return (
- <ResponsiveDialog open={dialogOpen} onOpenChange={setDialogOpen}>
- <ResponsiveDialogTrigger asChild>
+ <Dialog open={dialogOpen} onOpenChange={setDialogOpen}>
+ <DialogTrigger asChild>
{trigger ?? (
<Button variant="ghost" size="icon">
<Settings className="h-4 w-4" />
</Button>
)}
- </ResponsiveDialogTrigger>
- <ResponsiveDialogContent className="sm:max-w-[750px] p-4 sm:p-6 space-y-2">
- <ResponsiveDialogHeader>
- <ResponsiveDialogTitle>Site Settings</ResponsiveDialogTitle>
- <ResponsiveDialogDescription>Manage settings for {siteMetadata.domain}</ResponsiveDialogDescription>
- </ResponsiveDialogHeader>
+ </DialogTrigger>
+ <DialogContent className="sm:max-w-[750px]">
+ <DialogHeader>
+ <DialogTitle>Site Settings</DialogTitle>
+ <DialogDescription>Manage settings for {siteMetadata.domain}</DialogDescription>
+ </DialogHeader>
<Tabs value={activeTab} onValueChange={setActiveTab} className="pb-4">
<TabsList className="grid w-full grid-cols-3">
<TabsTrigger value="settings">Site Settings</TabsTrigger>
@@ -75,13 +77,13 @@ function SiteSettingsInner({ siteMetadata, trigger }: { siteMetadata: SiteRespon
<SiteConfiguration siteMetadata={siteMetadata} disabled={disabled} onClose={() => setDialogOpen(false)} />
</TabsContent>
</Tabs>
- {/*
- <ResponsiveDialogFooter className="pb-4">
- <ResponsiveDialogClose asChild>
+
+ <DialogFooter>
+ <DialogClose asChild>
<Button variant="outline">Close</Button>
- </ResponsiveDialogClose>
- </ResponsiveDialogFooter> */}
- </ResponsiveDialogContent>
- </ResponsiveDialog>
+ </DialogClose>
+ </DialogFooter>
+ </DialogContent>
+ </Dialog>
);
}