Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Do not suggest logging dropped items twice (#6448)

Adrián Chaves03a15ced4f0a
diff --git a/docs/topics/item-pipeline.rst b/docs/topics/item-pipeline.rst
index a5f6e07b8..58c922e0d 100644
--- a/docs/topics/item-pipeline.rst
+++ b/docs/topics/item-pipeline.rst
@@ -99,7 +99,7 @@ contain a price:
adapter["price"] = adapter["price"] * self.vat_factor
return item
else:
- raise DropItem(f"Missing price in {item}")
+ raise DropItem("Missing price")
Write items to a JSON lines file
@@ -254,7 +254,7 @@ returns multiples items with the same id:
def process_item(self, item, spider):
adapter = ItemAdapter(item)
if adapter["id"] in self.ids_seen:
- raise DropItem(f"Duplicate item found: {item!r}")
+ raise DropItem(f"Item ID already seen: {adapter['id']}")
else:
self.ids_seen.add(adapter["id"])
return item