Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

fix engine tests - this callback (spider_closed_callback) should accept one argument, but the error was hidden on py2

Konstantin Lopuhin0b08b4bfcfb6
diff --git a/tests/test_engine.py b/tests/test_engine.py
index df68e5281..9f2c02bff 100644
--- a/tests/test_engine.py
+++ b/tests/test_engine.py
@@ -238,12 +238,12 @@ class EngineTest(unittest.TestCase):
@defer.inlineCallbacks
def test_close_downloader(self):
- e = ExecutionEngine(get_crawler(TestSpider), lambda: None)
+ e = ExecutionEngine(get_crawler(TestSpider), lambda _: None)
yield e.close()
@defer.inlineCallbacks
def test_close_spiders_downloader(self):
- e = ExecutionEngine(get_crawler(TestSpider), lambda: None)
+ e = ExecutionEngine(get_crawler(TestSpider), lambda _: None)
yield e.open_spider(TestSpider(), [])
self.assertEqual(len(e.open_spiders), 1)
yield e.close()
@@ -251,7 +251,7 @@ class EngineTest(unittest.TestCase):
@defer.inlineCallbacks
def test_close_engine_spiders_downloader(self):
- e = ExecutionEngine(get_crawler(TestSpider), lambda: None)
+ e = ExecutionEngine(get_crawler(TestSpider), lambda _: None)
yield e.open_spider(TestSpider(), [])
e.start()
self.assertTrue(e.running)