Scrapy, a fast high-level web crawling & scraping framework for Python.
Update test expectations
Adrián Chaves0bf29a7b1b9b
diff --git a/scrapy/downloadermiddlewares/httpcompression.py b/scrapy/downloadermiddlewares/httpcompression.pyindex 5dd67ea87..0fec05a14 100644--- a/scrapy/downloadermiddlewares/httpcompression.py+++ b/scrapy/downloadermiddlewares/httpcompression.py@@ -30,7 +30,9 @@ class HttpCompressionMiddleware:"""This middleware allows compressed (gzip, deflate) traffic to besent/received from web sites"""- def __init__(self, crawler=None):+ def __init__(self, *, crawler=None):+ if not crawler:+ returnself.stats = crawler.statsself._max_size = crawler.settings.getint("DOWNLOAD_MAXSIZE")diff --git a/tests/test_downloadermiddleware_httpcompression.py b/tests/test_downloadermiddleware_httpcompression.pyindex f834e78f5..f5dedd28d 100644--- a/tests/test_downloadermiddleware_httpcompression.py+++ b/tests/test_downloadermiddleware_httpcompression.py@@ -127,18 +127,6 @@ class HttpCompressionTest(TestCase):self.assertStatsEqual("httpcompression/response_count", 1)self.assertStatsEqual("httpcompression/response_bytes", 74837)- def test_process_response_gzip_no_stats(self):- mw = HttpCompressionMiddleware()- response = self._getresponse("gzip")- request = response.request-- self.assertEqual(response.headers["Content-Encoding"], b"gzip")- newresponse = mw.process_response(request, response, self.spider)- self.assertEqual(mw.stats, None)- assert newresponse is not response- assert newresponse.body.startswith(b"<!DOCTYPE")- assert "Content-Encoding" not in newresponse.headers-def test_process_response_br(self):try:import brotli # noqa: F401@@ -418,8 +406,8 @@ class HttpCompressionSubclassTest(TestCase):(("HttpCompressionMiddleware subclasses must either modify "- "their '__init__' method to support a 'stats' parameter "- "or reimplement the 'from_crawler' method."+ "their '__init__' method to support a 'crawler' parameter "+ "or reimplement their 'from_crawler' method."),),)