Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Update reactor.py, updated 'if' sequencing , possibly eliminating a bug if portrange=None

Shivam Sandbhor18d0affc015c
diff --git a/scrapy/utils/reactor.py b/scrapy/utils/reactor.py
index 83186a372..eda7867e3 100644
--- a/scrapy/utils/reactor.py
+++ b/scrapy/utils/reactor.py
@@ -3,10 +3,10 @@ from twisted.internet import reactor, error
def listen_tcp(portrange, host, factory):
"""Like reactor.listenTCP but tries different ports in a range."""
assert len(portrange) <= 2, "invalid portrange: %s" % portrange
- if not hasattr(portrange, '__iter__'):
- return reactor.listenTCP(portrange, factory, interface=host)
if not portrange:
return reactor.listenTCP(0, factory, interface=host)
+ if not hasattr(portrange, '__iter__'):
+ return reactor.listenTCP(portrange, factory, interface=host)
if len(portrange) == 1:
return reactor.listenTCP(portrange[0], factory, interface=host)
for x in range(portrange[0], portrange[1]+1):