Scrapy, a fast high-level web crawling & scraping framework for Python.
Move logging of overriden settings to Crawler init
Paul Tremberth1968a8ec0291
diff --git a/scrapy/crawler.py b/scrapy/crawler.pyindex 1367536ab..0a56ef57a 100644--- a/scrapy/crawler.py+++ b/scrapy/crawler.py@@ -11,7 +11,7 @@ from scrapy.core.engine import ExecutionEnginefrom scrapy.resolver import CachingThreadedResolverfrom scrapy.interfaces import ISpiderLoaderfrom scrapy.extension import ExtensionManager-from scrapy.settings import Settings+from scrapy.settings import overridden_settings, Settingsfrom scrapy.signalmanager import SignalManagerfrom scrapy.exceptions import ScrapyDeprecationWarningfrom scrapy.utils.ossignal import install_shutdown_handlers, signal_names@@ -34,6 +34,9 @@ class Crawler(object):self.settings = settings.copy()self.spidercls.update_settings(self.settings)+ d = dict(overridden_settings(self.settings))+ logger.info("Overridden settings: %(settings)r", {'settings': d})+self.signals = SignalManager(self)self.stats = load_object(self.settings['STATS_CLASS'])(self)diff --git a/scrapy/utils/log.py b/scrapy/utils/log.pyindex 905c1bfc1..c6d1cdf46 100644--- a/scrapy/utils/log.py+++ b/scrapy/utils/log.py@@ -9,7 +9,7 @@ from twisted.python.failure import Failurefrom twisted.python import log as twisted_logimport scrapy-from scrapy.settings import overridden_settings, Settings+from scrapy.settings import Settingsfrom scrapy.exceptions import ScrapyDeprecationWarningfrom scrapy.utils.versions import scrapy_components_versions@@ -148,8 +148,6 @@ def log_scrapy_info(settings):{'versions': ", ".join("%s %s" % (name, version)for name, version in scrapy_components_versions()if name != "Scrapy")})- d = dict(overridden_settings(settings))- logger.info("Overridden settings: %(settings)r", {'settings': d})class StreamLogger(object):