Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Allow use without credentials

nyov2829cd4268d2
diff --git a/scrapy/extensions/feedexport.py b/scrapy/extensions/feedexport.py
index e793c12dc..68d6533d3 100644
--- a/scrapy/extensions/feedexport.py
+++ b/scrapy/extensions/feedexport.py
@@ -94,10 +94,6 @@ class FileFeedStorage:
class S3FeedStorage(BlockingFeedStorage):
def __init__(self, uri, access_key=None, secret_key=None, acl=None):
- no_keys = access_key is None and secret_key is None
- if no_keys:
- raise NotConfigured('%s is missing AWS credentials' %
- self.__class__.__name__)
u = urlparse(uri)
self.bucketname = u.hostname
self.access_key = u.username or access_key
diff --git a/tests/test_feedexport.py b/tests/test_feedexport.py
index 34a67fff3..656bb515f 100644
--- a/tests/test_feedexport.py
+++ b/tests/test_feedexport.py
@@ -24,7 +24,6 @@ from zope.interface.verify import verifyObject
import scrapy
from scrapy.crawler import CrawlerRunner
-from scrapy.exceptions import NotConfigured
from scrapy.exporters import CsvItemExporter
from scrapy.extensions.feedexport import (
BlockingFeedStorage,
@@ -202,9 +201,6 @@ class S3FeedStorageTest(unittest.TestCase):
aws_credentials['AWS_SECRET_ACCESS_KEY'])
self.assertEqual(storage.access_key, 'uri_key')
self.assertEqual(storage.secret_key, 'uri_secret')
- # Instantiate without credentials
- with self.assertRaises(NotConfigured):
- S3FeedStorage('s3://mybucket/export.csv')
@defer.inlineCallbacks
def test_store(self):