Scrapy, a fast high-level web crawling & scraping framework for Python.
Allow use without credentials
nyov2829cd4268d2
diff --git a/scrapy/extensions/feedexport.py b/scrapy/extensions/feedexport.pyindex e793c12dc..68d6533d3 100644--- a/scrapy/extensions/feedexport.py+++ b/scrapy/extensions/feedexport.py@@ -94,10 +94,6 @@ class FileFeedStorage:class S3FeedStorage(BlockingFeedStorage):def __init__(self, uri, access_key=None, secret_key=None, acl=None):- no_keys = access_key is None and secret_key is None- if no_keys:- raise NotConfigured('%s is missing AWS credentials' %- self.__class__.__name__)u = urlparse(uri)self.bucketname = u.hostnameself.access_key = u.username or access_keydiff --git a/tests/test_feedexport.py b/tests/test_feedexport.pyindex 34a67fff3..656bb515f 100644--- a/tests/test_feedexport.py+++ b/tests/test_feedexport.py@@ -24,7 +24,6 @@ from zope.interface.verify import verifyObjectimport scrapyfrom scrapy.crawler import CrawlerRunner-from scrapy.exceptions import NotConfiguredfrom scrapy.exporters import CsvItemExporterfrom scrapy.extensions.feedexport import (BlockingFeedStorage,@@ -202,9 +201,6 @@ class S3FeedStorageTest(unittest.TestCase):aws_credentials['AWS_SECRET_ACCESS_KEY'])self.assertEqual(storage.access_key, 'uri_key')self.assertEqual(storage.secret_key, 'uri_secret')- # Instantiate without credentials- with self.assertRaises(NotConfigured):- S3FeedStorage('s3://mybucket/export.csv')@defer.inlineCallbacksdef test_store(self):