Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Add test for fetch(url) within shell with and without redirect

Paul Tremberth2cd579a7748d
diff --git a/tests/test_command_shell.py b/tests/test_command_shell.py
index ee6e8ad8e..3e27d6abd 100644
--- a/tests/test_command_shell.py
+++ b/tests/test_command_shell.py
@@ -59,6 +59,25 @@ class ShellTest(ProcessTest, SiteTest, unittest.TestCase):
_, out, _ = yield self.execute(['--no-redirect', self.url('/redirect-no-meta-refresh'), '-c', 'response.status'])
assert out.strip().endswith(b'302')
+ @defer.inlineCallbacks
+ def test_fetch_redirect_follow_302(self):
+ """Test that calling `fetch(url)` follows HTTP redirects by default."""
+ url = self.url('/redirect-no-meta-refresh')
+ code = "fetch('{0}')"
+ errcode, out, errout = yield self.execute(['-c', code.format(url)])
+ self.assertEqual(errcode, 0, out)
+ assert b'Redirecting (302)' in errout
+ assert b'Crawled (200)' in errout
+
+ @defer.inlineCallbacks
+ def test_fetch_redirect_not_follow_302(self):
+ """Test that calling `fetch(url, redirect=False)` disables automatic redirects."""
+ url = self.url('/redirect-no-meta-refresh')
+ code = "fetch('{0}', redirect=False)"
+ errcode, out, errout = yield self.execute(['-c', code.format(url)])
+ self.assertEqual(errcode, 0, out)
+ assert b'Crawled (302)' in errout
+
@defer.inlineCallbacks
def test_request_replace(self):
url = self.url('/text')