Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Use settings instead of crawler

Eugenio Lacuesta2fb160e3bac9
diff --git a/scrapy/core/downloader/handlers/ftp.py b/scrapy/core/downloader/handlers/ftp.py
index 89c88ad70..1681c6df8 100644
--- a/scrapy/core/downloader/handlers/ftp.py
+++ b/scrapy/core/downloader/handlers/ftp.py
@@ -71,14 +71,14 @@ class FTPDownloadHandler:
"default": 503,
}
- def __init__(self, settings, crawler=None):
+ def __init__(self, settings):
self.default_user = settings['FTP_USER']
self.default_password = settings['FTP_PASSWORD']
self.passive_mode = settings['FTP_PASSIVE_MODE']
@classmethod
def from_crawler(cls, crawler):
- return cls(crawler.settings, crawler)
+ return cls(crawler.settings)
def download_request(self, request, spider):
parsed_url = urlparse_cached(request)
diff --git a/scrapy/core/downloader/handlers/http10.py b/scrapy/core/downloader/handlers/http10.py
index 1086a6cc0..87a42f1da 100644
--- a/scrapy/core/downloader/handlers/http10.py
+++ b/scrapy/core/downloader/handlers/http10.py
@@ -10,8 +10,8 @@ class HTTP10DownloadHandler:
lazy = False
def __init__(self, settings, crawler=None):
- self.HTTPClientFactory = load_object(crawler.settings['DOWNLOADER_HTTPCLIENTFACTORY'])
- self.ClientContextFactory = load_object(crawler.settings['DOWNLOADER_CLIENTCONTEXTFACTORY'])
+ self.HTTPClientFactory = load_object(settings['DOWNLOADER_HTTPCLIENTFACTORY'])
+ self.ClientContextFactory = load_object(settings['DOWNLOADER_CLIENTCONTEXTFACTORY'])
self._settings = settings
self._crawler = crawler