Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Remove deprecated CrawlerRunner.spiders. (#6010)

Andrey Rakhmatullin34d050cfe5ae
diff --git a/scrapy/crawler.py b/scrapy/crawler.py
index c5b3e1903..bc0ab02df 100644
--- a/scrapy/crawler.py
+++ b/scrapy/crawler.py
@@ -204,16 +204,6 @@ class CrawlerRunner:
self._active: Set[defer.Deferred] = set()
self.bootstrap_failed = False
- @property
- def spiders(self):
- warnings.warn(
- "CrawlerRunner.spiders attribute is renamed to "
- "CrawlerRunner.spider_loader.",
- category=ScrapyDeprecationWarning,
- stacklevel=2,
- )
- return self.spider_loader
-
def crawl(self, crawler_or_spidercls, *args, **kwargs):
"""
Run a crawler with the provided arguments.
diff --git a/tests/test_crawler.py b/tests/test_crawler.py
index f99606ccf..4c5c48e6d 100644
--- a/tests/test_crawler.py
+++ b/tests/test_crawler.py
@@ -20,7 +20,6 @@ from scrapy.extensions.throttle import AutoThrottle
from scrapy.settings import Settings, default_settings
from scrapy.spiderloader import SpiderLoader
from scrapy.utils.log import configure_logging, get_scrapy_root_handler
-from scrapy.utils.misc import load_object
from scrapy.utils.spider import DefaultSpider
from scrapy.utils.test import get_crawler
from tests.mockserver import MockServer, get_mockserver_env
@@ -182,16 +181,6 @@ class CrawlerRunnerTestCase(BaseCrawlerTest):
runner = CrawlerRunner()
self.assertOptionIsDefault(runner.settings, "RETRY_ENABLED")
- def test_deprecated_attribute_spiders(self):
- with warnings.catch_warnings(record=True) as w:
- runner = CrawlerRunner(Settings())
- spiders = runner.spiders
- self.assertEqual(len(w), 1)
- self.assertIn("CrawlerRunner.spiders", str(w[0].message))
- self.assertIn("CrawlerRunner.spider_loader", str(w[0].message))
- sl_cls = load_object(runner.settings["SPIDER_LOADER_CLASS"])
- self.assertIsInstance(spiders, sl_cls)
-
class CrawlerProcessTest(BaseCrawlerTest):
def test_crawler_process_accepts_dict(self):