Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Add typing to scrapy/utils/engine.py.

Andrey Rakhmatullin36507ddb7b55
diff --git a/scrapy/utils/engine.py b/scrapy/utils/engine.py
index 8e3ec2c37..a5f2a8c6e 100644
--- a/scrapy/utils/engine.py
+++ b/scrapy/utils/engine.py
@@ -2,9 +2,13 @@
# used in global tests code
from time import time # noqa: F401
+from typing import TYPE_CHECKING, Any, List, Tuple
+if TYPE_CHECKING:
+ from scrapy.core.engine import ExecutionEngine
-def get_engine_status(engine):
+
+def get_engine_status(engine: "ExecutionEngine") -> List[Tuple[str, Any]]:
"""Return a report of the current engine status"""
tests = [
"time()-engine.start_time",
@@ -23,7 +27,7 @@ def get_engine_status(engine):
"engine.scraper.slot.needs_backout()",
]
- checks = []
+ checks: List[Tuple[str, Any]] = []
for test in tests:
try:
checks += [(test, eval(test))]
@@ -33,7 +37,7 @@ def get_engine_status(engine):
return checks
-def format_engine_status(engine=None):
+def format_engine_status(engine: "ExecutionEngine") -> str:
checks = get_engine_status(engine)
s = "Execution engine status\n\n"
for test, result in checks:
@@ -43,5 +47,5 @@ def format_engine_status(engine=None):
return s
-def print_engine_status(engine):
+def print_engine_status(engine: "ExecutionEngine") -> None:
print(format_engine_status(engine))