Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Mention that ScrapyHTTPClientFactory has Twisted code

Adrián Chaves42954d0df9a7
diff --git a/scrapy/core/downloader/webclient.py b/scrapy/core/downloader/webclient.py
index 16fd214a3..26726afd4 100644
--- a/scrapy/core/downloader/webclient.py
+++ b/scrapy/core/downloader/webclient.py
@@ -93,6 +93,10 @@ class ScrapyHTTPPageGetter(HTTPClient):
(self.factory.url, self.factory.timeout)))
+# This class used to inherit from Twisted’s
+# twisted.web.client.HTTPClientFactory. When that class was deprecated in
+# Twisted (https://github.com/twisted/twisted/pull/643), we merged its
+# non-overriden code into this class.
class ScrapyHTTPClientFactory(ClientFactory):
protocol = ScrapyHTTPPageGetter