Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Fix warning: Expected type 'bool', got 'int' instead (#4940)

Kader DJEHAF44a7ab5bf06b
diff --git a/scrapy/pipelines/media.py b/scrapy/pipelines/media.py
index 0a12f3e2c..0c2ee6856 100644
--- a/scrapy/pipelines/media.py
+++ b/scrapy/pipelines/media.py
@@ -86,7 +86,7 @@ class MediaPipeline:
info = self.spiderinfo
requests = arg_to_iter(self.get_media_requests(item, info))
dlist = [self._process_request(r, info, item) for r in requests]
- dfd = DeferredList(dlist, consumeErrors=1)
+ dfd = DeferredList(dlist, consumeErrors=True)
return dfd.addCallback(self.item_completed, item, info)
def _process_request(self, request, info, item):
diff --git a/scrapy/utils/defer.py b/scrapy/utils/defer.py
index 21ba02a0b..6db9cc117 100644
--- a/scrapy/utils/defer.py
+++ b/scrapy/utils/defer.py
@@ -105,7 +105,7 @@ def process_parallel(callbacks, input, *a, **kw):
callbacks
"""
dfds = [defer.succeed(input).addCallback(x, *a, **kw) for x in callbacks]
- d = defer.DeferredList(dfds, fireOnOneErrback=1, consumeErrors=1)
+ d = defer.DeferredList(dfds, fireOnOneErrback=True, consumeErrors=True)
d.addCallbacks(lambda r: [x[1] for x in r], lambda f: f.value.subFailure)
return d