Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Remove _check_signature

Laerte Pereira4ad727f0b566
diff --git a/scrapy/pipelines/media.py b/scrapy/pipelines/media.py
index 34ab18404..75532034a 100644
--- a/scrapy/pipelines/media.py
+++ b/scrapy/pipelines/media.py
@@ -1,8 +1,6 @@
import functools
import logging
from collections import defaultdict
-from inspect import signature
-from warnings import warn
from twisted.internet.defer import Deferred, DeferredList
from twisted.python.failure import Failure
@@ -11,7 +9,6 @@ from scrapy.http.request import NO_CALLBACK
from scrapy.settings import Settings
from scrapy.utils.datatypes import SequenceExclude
from scrapy.utils.defer import defer_result, mustbe_deferred
-from scrapy.utils.deprecate import ScrapyDeprecationWarning
from scrapy.utils.log import failure_to_exc_info
from scrapy.utils.misc import arg_to_iter
@@ -123,21 +120,6 @@ class MediaPipeline:
)
return dfd.addBoth(lambda _: wad) # it must return wad at last
- def _check_signature(self, func):
- sig = signature(func)
- self._expects_item[func.__name__] = True
-
- if "item" not in sig.parameters:
- old_params = str(sig)[1:-1]
- new_params = old_params + ", *, item=None"
- warn(
- f"{func.__name__}(self, {old_params}) is deprecated, "
- f"please use {func.__name__}(self, {new_params})",
- ScrapyDeprecationWarning,
- stacklevel=2,
- )
- self._expects_item[func.__name__] = False
-
def _modify_media_request(self, request):
if self.handle_httpstatus_list:
request.meta["handle_httpstatus_list"] = self.handle_httpstatus_list