Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

fixing oversight from #7036 (#7367)

Albert Eduardovich N.5561aaec1d68
diff --git a/scrapy/http/request/__init__.py b/scrapy/http/request/__init__.py
index c4a0c8131..f523c2bb9 100644
--- a/scrapy/http/request/__init__.py
+++ b/scrapy/http/request/__init__.py
@@ -242,20 +242,12 @@ class Request(object_ref):
self._cb_kwargs = {}
return self._cb_kwargs
- @cb_kwargs.setter
- def cb_kwargs(self, value: dict[str, Any] | None) -> None:
- self._cb_kwargs = value or None
-
@property
def meta(self) -> dict[str, Any]:
if self._meta is None:
self._meta = {}
return self._meta
- @meta.setter
- def meta(self, value: dict[str, Any] | None) -> None:
- self._meta = value or None
-
@property
def url(self) -> str:
return self._url
diff --git a/tests/test_http_request.py b/tests/test_http_request.py
index 06b280235..81f8fa3c1 100644
--- a/tests/test_http_request.py
+++ b/tests/test_http_request.py
@@ -320,12 +320,6 @@ class TestRequest:
def test_setters(self):
request = self.request_class("http://example.com")
- request.cb_kwargs = {"a": 1}
- assert request.cb_kwargs == {"a": 1}
-
- request.meta = {"k": "v"}
- assert request.meta == {"k": "v"}
-
request.flags = ["f1"]
assert request.flags == ["f1"]
@@ -349,24 +343,6 @@ class TestRequest:
request = self.request_class("http://example.com")
- assert request._cb_kwargs is None
- assert request.cb_kwargs == {}
- assert request.cb_kwargs is request.cb_kwargs
- assert request._cb_kwargs == {}
- original_cb_kwargs = request.cb_kwargs
- request.cb_kwargs = None
- assert request.cb_kwargs == {}
- assert request.cb_kwargs is not original_cb_kwargs
-
- assert request._meta is None
- assert request.meta == {}
- assert request.meta is request.meta
- assert request._meta == {}
- original_meta = request.meta
- request.meta = None
- assert request.meta == {}
- assert request.meta is not original_meta
-
assert request._flags is None
assert request.flags == []
assert request.flags is request.flags