Scrapy, a fast high-level web crawling & scraping framework for Python.
Count keyword argument checks
Eugenio Lacuesta645e8d16a4c9
diff --git a/tests/spiders.py b/tests/spiders.pyindex 5a1471072..7b4707f62 100644--- a/tests/spiders.py+++ b/tests/spiders.py@@ -31,7 +31,7 @@ class MetaSpider(MockServerSpider):class KeywordArgumentsSpider(MockServerSpider):name = 'kwargs'- checks = set()+ checks = list()def start_requests(self):data = {'key': 'value', 'number': 123}@@ -41,25 +41,30 @@ class KeywordArgumentsSpider(MockServerSpider):yield Request(self.mockserver.url('/no_kwargs'), self.parse_no_kwargs)def parse_first(self, response, key, number):- self.checks.add(key == 'value')- self.checks.add(number == 123)+ self.checks.append(key == 'value')+ self.checks.append(number == 123)+ self.crawler.stats.inc_value('boolean_checks', 2)yield response.follow(self.mockserver.url('/two'),self.parse_second,kwargs={'new_key': 'new_value'})def parse_second(self, response, new_key):- self.checks.add(new_key == 'new_value')+ self.checks.append(new_key == 'new_value')+ self.crawler.stats.inc_value('boolean_checks')def parse_general(self, response, **kwargs):if response.url.endswith('/general_with'):- self.checks.add(kwargs['key'] == 'value')- self.checks.add(kwargs['number'] == 123)+ self.checks.append(kwargs['key'] == 'value')+ self.checks.append(kwargs['number'] == 123)+ self.crawler.stats.inc_value('boolean_checks', 2)elif response.url.endswith('/general_without'):- self.checks.add(kwargs == {})+ self.checks.append(kwargs == {})+ self.crawler.stats.inc_value('boolean_checks')def parse_no_kwargs(self, response):- pass+ self.checks.append(response.url.endswith('/no_kwargs'))+ self.crawler.stats.inc_value('boolean_checks')class FollowAllSpider(MetaSpider):diff --git a/tests/test_crawl.py b/tests/test_crawl.pyindex 3879a017c..9a39b8cb4 100644--- a/tests/test_crawl.py+++ b/tests/test_crawl.py@@ -27,7 +27,8 @@ class CrawlTestCase(TestCase):def test_callback_kwargs(self):crawler = self.runner.create_crawler(KeywordArgumentsSpider)yield crawler.crawl(mockserver=self.mockserver)- self.assertEqual(crawler.spider.checks, set([True]))+ self.assertTrue(all(crawler.spider.checks))+ self.assertEqual(len(crawler.spider.checks), crawler.stats.get_value('boolean_checks'))@defer.inlineCallbacksdef test_follow_all(self):