Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

makes suggested changes

Anubhav Patel653ac3eebe96
diff --git a/scrapy/pipelines/images.py b/scrapy/pipelines/images.py
index 9776817bc..b95383b3b 100644
--- a/scrapy/pipelines/images.py
+++ b/scrapy/pipelines/images.py
@@ -155,7 +155,6 @@ class ImagesPipeline(FilesPipeline):
for thumb_id, size in six.iteritems(self.thumbs):
thumb_path = self.thumb_path(request, thumb_id, response=response, info=info)
if convert_image_overriden:
- _warn()
thumb_image, thumb_buf = self.convert_image(image, size)
else:
thumb_image, thumb_buf = self.convert_image(image, size, buf)
diff --git a/tests/test_pipeline_images.py b/tests/test_pipeline_images.py
index 1dfca5c11..ba79dd6bd 100644
--- a/tests/test_pipeline_images.py
+++ b/tests/test_pipeline_images.py
@@ -108,7 +108,7 @@ class ImagesPipelineTestCase(unittest.TestCase):
self.assertEqual(converted.getcolors(), [(10000, (205, 230, 255))])
# ensure that we recieved deprecation warnings
- self.assertTrue(len(w) >= 4)
+ self.assertTrue(len([warning for warning in w if 'ImagesPipeline.convert_image() method called in a incompatible way' in str(warning.message)]) == 4)
# tests for new API
SIZE = (100, 100)