Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Cookies: Cast primitive types to str (#5253)

Laerte6c858cec91b0
diff --git a/scrapy/downloadermiddlewares/cookies.py b/scrapy/downloadermiddlewares/cookies.py
index d95ed3d38..0eee8d758 100644
--- a/scrapy/downloadermiddlewares/cookies.py
+++ b/scrapy/downloadermiddlewares/cookies.py
@@ -80,8 +80,8 @@ class CookiesMiddleware:
logger.warning(msg.format(request, cookie, key))
return
continue
- if isinstance(cookie[key], str):
- decoded[key] = cookie[key]
+ if isinstance(cookie[key], (bool, float, int, str)):
+ decoded[key] = str(cookie[key])
else:
try:
decoded[key] = cookie[key].decode("utf8")
diff --git a/tests/test_downloadermiddleware_cookies.py b/tests/test_downloadermiddleware_cookies.py
index aff8542e9..36021bfbf 100644
--- a/tests/test_downloadermiddleware_cookies.py
+++ b/tests/test_downloadermiddleware_cookies.py
@@ -347,3 +347,24 @@ class CookiesMiddlewareTest(TestCase):
self.assertCookieValEqual(req1.headers['Cookie'], 'key=value1')
self.assertCookieValEqual(req2.headers['Cookie'], 'key=value2')
self.assertCookieValEqual(req3.headers['Cookie'], 'key=')
+
+ def test_primitive_type_cookies(self):
+ # Boolean
+ req1 = Request('http://example.org', cookies={'a': True})
+ assert self.mw.process_request(req1, self.spider) is None
+ self.assertCookieValEqual(req1.headers['Cookie'], b'a=True')
+
+ # Float
+ req2 = Request('http://example.org', cookies={'a': 9.5})
+ assert self.mw.process_request(req2, self.spider) is None
+ self.assertCookieValEqual(req2.headers['Cookie'], b'a=9.5')
+
+ # Integer
+ req3 = Request('http://example.org', cookies={'a': 10})
+ assert self.mw.process_request(req3, self.spider) is None
+ self.assertCookieValEqual(req3.headers['Cookie'], b'a=10')
+
+ # String
+ req4 = Request('http://example.org', cookies={'a': 'b'})
+ assert self.mw.process_request(req4, self.spider) is None
+ self.assertCookieValEqual(req4.headers['Cookie'], b'a=b')