Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

ENH Pass arguments to logger rather than formatted message.

Rolando Espinoza6dec4a3ccb45
diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py
index 54aa359fb..ecd7f90d3 100644
--- a/scrapy/core/downloader/handlers/http11.py
+++ b/scrapy/core/downloader/handlers/http11.py
@@ -319,14 +319,13 @@ class ScrapyAgent(object):
expected_size = txresponse.length if txresponse.length != UNKNOWN_LENGTH else -1
if maxsize and expected_size > maxsize:
- error_message = ("Cancelling download of {url}: expected response "
- "size ({size}) larger than "
- "download max size ({maxsize})."
- ).format(url=request.url, size=expected_size, maxsize=maxsize)
+ error_msg = ("Cancelling download of %(url)s: expected response "
+ "size (%(size)s) larger than download max size (%(maxsize)s).")
+ error_args = {'url': request.url, 'size': expected_size, 'maxsize': maxsize}
- logger.error(error_message)
+ logger.error(error_msg, error_args)
txresponse._transport._producer.loseConnection()
- raise defer.CancelledError(error_message)
+ raise defer.CancelledError(error_msg % error_args)
if warnsize and expected_size > warnsize:
logger.warning("Expected response size (%(size)s) larger than "