Scrapy, a fast high-level web crawling & scraping framework for Python.
Implement docs suggestions.
Andrey Rakhmatullin6eaceec735d5
diff --git a/docs/news.rst b/docs/news.rstindex 509366c17..2afe318f6 100644--- a/docs/news.rst+++ b/docs/news.rst@@ -1,3 +1,25 @@+.. note::+ .. versionchanged:: VERSION++ The Twisted reactor is now installed when+ :meth:`~scrapy.crawler.CrawlerProcess.crawl` is first called, not when a+ :class:`scrapy.crawler.CrawlerProcess` object is created. Because of this,+ :setting:`TWISTED_REACTOR` and :setting:`ASYNCIO_EVENT_LOOP` are now+ honored in :attr:`~scrapy.Spider.custom_settings`. In older Scrapy versions+ they are silently ignored when set there and you need to set these settings+ in some other way.+++.. note::+ .. versionchanged:: VERSION++ Previously this setting had no effect in a spider+ :attr:`~scrapy.Spider.custom_settings` attribute. Now it will be used, but+ if you :ref:`run several spiders in one process <run-multiple-spiders>`,+ they must not have different values for this setting, because they will use+ a single reactor instance.++.. _news:Release notesdiff --git a/docs/topics/practices.rst b/docs/topics/practices.rstindex bd0dd8ce0..1a9d56143 100644--- a/docs/topics/practices.rst+++ b/docs/topics/practices.rst@@ -102,17 +102,6 @@ reactor after ``MySpider`` has finished running.d.addBoth(lambda _: reactor.stop())reactor.run() # the script will block here until the crawling is finished-.. note::- .. versionchanged:: VERSION-- The Twisted reactor is now installed when- :meth:`~scrapy.crawler.CrawlerProcess.crawl` is first called, not when a- :class:`scrapy.crawler.CrawlerProcess` object is created. Because of this,- :setting:`TWISTED_REACTOR` and :setting:`ASYNCIO_EVENT_LOOP` are now- honored in :attr:`~scrapy.Spider.custom_settings`. In older Scrapy versions- they are silently ignored when set there and you need to set these settings- in some other way.-.. seealso:: :doc:`twisted:core/howto/reactor-basics`.. _run-multiple-spiders:diff --git a/docs/topics/settings.rst b/docs/topics/settings.rstindex cff6d80cb..f6c95c502 100644--- a/docs/topics/settings.rst+++ b/docs/topics/settings.rst@@ -1639,17 +1639,8 @@ which raises :exc:`Exception`, becomes::The default value of the :setting:`TWISTED_REACTOR` setting is ``None``, whichmeans that Scrapy will install the default reactor defined by Twisted for the-current platform will be used. This is to maintain backward compatibility and-avoid possible problems caused by using a non-default reactor.--.. note::- .. versionchanged:: VERSION-- Previously this setting had no effect in a spider- :attr:`~scrapy.Spider.custom_settings` attribute. Now it will be used, but- if you :ref:`run several spiders in one process <run-multiple-spiders>`,- they must not have different values for this setting, because they will use- a single reactor instance.+current platform. This is to maintain backward compatibility and avoid possible+problems caused by using a non-default reactor.For additional information, see :doc:`core/howto/choosing-reactor`.