Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

using named params with optional amazon s3 params

Victor Torres7c9f0bd86c5f
diff --git a/scrapy/extensions/feedexport.py b/scrapy/extensions/feedexport.py
index 2b4594ad8..f6bc460ea 100644
--- a/scrapy/extensions/feedexport.py
+++ b/scrapy/extensions/feedexport.py
@@ -131,9 +131,12 @@ class S3FeedStorage(BlockingFeedStorage):
@classmethod
def from_crawler(cls, crawler, uri):
- return cls(uri, crawler.settings['AWS_ACCESS_KEY_ID'],
- crawler.settings['AWS_SECRET_ACCESS_KEY'],
- crawler.settings['FEED_STORAGE_S3_ACL'])
+ return cls(
+ uri=uri,
+ access_key=crawler.settings['AWS_ACCESS_KEY_ID'],
+ secret_key=crawler.settings['AWS_SECRET_ACCESS_KEY'],
+ acl=crawler.settings['FEED_STORAGE_S3_ACL']
+ )
def _store_in_thread(self, file):
file.seek(0)