Scrapy, a fast high-level web crawling & scraping framework for Python.
Issue #3264, fix error handling when spider is not matched
Andreas Tziortziortziopoulos83c193928119
diff --git a/scrapy/commands/parse.py b/scrapy/commands/parse.pyindex a3f6b96f4..99fc8f955 100644--- a/scrapy/commands/parse.py+++ b/scrapy/commands/parse.py@@ -146,7 +146,8 @@ class Command(BaseRunSpiderCommand):def _start_requests(spider):yield self.prepare_request(spider, Request(url), opts)- self.spidercls.start_requests = _start_requests+ if self.spidercls:+ self.spidercls.start_requests = _start_requestsdef start_parsing(self, url, opts):self.crawler_process.crawl(self.spidercls, **opts.spargs)diff --git a/tests/test_command_parse.py b/tests/test_command_parse.pyindex f21ee971d..0622074a3 100644--- a/tests/test_command_parse.py+++ b/tests/test_command_parse.py@@ -1,6 +1,7 @@import osimport argparsefrom os.path import join, abspath, isfile, exists+from twisted.internet import deferfrom scrapy.commands import parsefrom scrapy.settings import Settings@@ -222,6 +223,10 @@ ITEM_PIPELINES = {{'{self.project_name}.pipelines.MyPipeline': 1}}self.assertRegex(_textmode(out), r"""# Scraped Items -+\n\[\]""")self.assertIn("""Cannot find a rule that matches""", _textmode(stderr))+ status, out, stderr = yield self.execute([self.url('/invalid_url')])+ self.assertEqual(status, 0)+ self.assertIn("""""", _textmode(stderr))+@defer.inlineCallbacksdef test_output_flag(self):"""Checks if a file was created successfully having