Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Deprecate scrapy.utils.python.MutableChain.next

Adrián Chaves99d8b05a0b19
diff --git a/scrapy/utils/python.py b/scrapy/utils/python.py
index 64402a2bb..6edf7d702 100644
--- a/scrapy/utils/python.py
+++ b/scrapy/utils/python.py
@@ -392,3 +392,7 @@ class MutableChain(object):
def __next__(self):
return next(self.data)
+
+ @deprecated("scrapy.utils.python.MutableChain.__next__")
+ def next(self):
+ return self.__next__()
diff --git a/tests/test_utils_python.py b/tests/test_utils_python.py
index 6cae9793d..ca2c241e4 100644
--- a/tests/test_utils_python.py
+++ b/tests/test_utils_python.py
@@ -5,6 +5,7 @@ import unittest
from itertools import count
import platform
import six
+from warnings import catch_warnings
from scrapy.utils.python import (
memoizemethod_noargs, binary_is_text, equal_attributes,
@@ -22,7 +23,12 @@ class MutableChainTest(unittest.TestCase):
m.extend([9, 10], (11, 12))
self.assertEqual(next(m), 0)
self.assertEqual(m.__next__(), 1)
- self.assertEqual(list(m), list(range(2, 13)))
+ with catch_warnings(record=True) as warnings:
+ self.assertEqual(m.next(), 2)
+ self.assertEqual(len(warnings), 1)
+ self.assertIn('scrapy.utils.python.MutableChain.__next__',
+ str(warnings[0].message))
+ self.assertEqual(list(m), list(range(3, 13)))
class ToUnicodeTest(unittest.TestCase):