Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Explicit argument names

Eugenio Lacuesta9a75b46fb832
diff --git a/scrapy/core/downloader/handlers/http10.py b/scrapy/core/downloader/handlers/http10.py
index 87a42f1da..d4aa51bd1 100644
--- a/scrapy/core/downloader/handlers/http10.py
+++ b/scrapy/core/downloader/handlers/http10.py
@@ -29,7 +29,7 @@ class HTTP10DownloadHandler:
host, port = to_unicode(factory.host), factory.port
if factory.scheme == b'https':
client_context_factory = create_instance(
- self.ClientContextFactory,
+ objcls=self.ClientContextFactory,
settings=self._settings,
crawler=self._crawler,
)
diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py
index d8a561792..5a5f6cf0a 100644
--- a/scrapy/core/downloader/handlers/http11.py
+++ b/scrapy/core/downloader/handlers/http11.py
@@ -41,7 +41,7 @@ class HTTP11DownloadHandler:
# try method-aware context factory
try:
self._contextFactory = create_instance(
- self._contextFactoryClass,
+ objcls=self._contextFactoryClass,
settings=settings,
crawler=crawler,
method=self._sslMethod,
@@ -49,7 +49,7 @@ class HTTP11DownloadHandler:
except TypeError:
# use context factory defaults
self._contextFactory = create_instance(
- self._contextFactoryClass,
+ objcls=self._contextFactoryClass,
settings=settings,
crawler=crawler,
)
diff --git a/scrapy/core/downloader/handlers/s3.py b/scrapy/core/downloader/handlers/s3.py
index 93cad0662..b38d2bf86 100644
--- a/scrapy/core/downloader/handlers/s3.py
+++ b/scrapy/core/downloader/handlers/s3.py
@@ -68,7 +68,11 @@ class S3DownloadHandler:
except Exception as ex:
raise NotConfigured(str(ex))
- _http_handler = create_instance(httpdownloadhandler, settings, crawler)
+ _http_handler = create_instance(
+ objcls=httpdownloadhandler,
+ settings=settings,
+ crawler=crawler,
+ )
self._download_http = _http_handler.download_request
@classmethod