Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

show all the missing field when scrapes contract fails

tpenga8621bbc2929
diff --git a/scrapy/contracts/default.py b/scrapy/contracts/default.py
index 20582503d..0f6bdbad2 100644
--- a/scrapy/contracts/default.py
+++ b/scrapy/contracts/default.py
@@ -84,6 +84,6 @@ class ScrapesContract(Contract):
def post_process(self, output):
for x in output:
if isinstance(x, (BaseItem, dict)):
- for arg in self.args:
- if not arg in x:
- raise ContractFail("'%s' field is missing" % arg)
+ missing = [arg for arg in self.args if arg not in x]
+ if missing:
+ raise ContractFail("'%s' field is missing" % " ".join(missing))