Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Fix request_httprepr() with all headers set to None. (#8266)

Andrey Rakhmatullinb05336f199d6
diff --git a/scrapy/utils/request.py b/scrapy/utils/request.py
index 53242176c..1e6b5bfb9 100644
--- a/scrapy/utils/request.py
+++ b/scrapy/utils/request.py
@@ -145,8 +145,8 @@ def request_httprepr(request: Request) -> bytes:
path = urlunparse(("", "", parsed.path or "/", parsed.params, parsed.query, ""))
s = to_bytes(request.method) + b" " + to_bytes(path) + b" HTTP/1.1\r\n"
s += b"Host: " + to_bytes(parsed.hostname or b"") + b"\r\n"
- if request.headers:
- s += request.headers.to_string() + b"\r\n"
+ if headers := request.headers.to_string():
+ s += headers + b"\r\n"
s += b"\r\n"
s += request.body
return s
diff --git a/tests/test_utils_request.py b/tests/test_utils_request.py
index 08e03970c..75c5fe1dc 100644
--- a/tests/test_utils_request.py
+++ b/tests/test_utils_request.py
@@ -41,6 +41,10 @@ if TYPE_CHECKING:
),
b"POST / HTTP/1.1\r\nHost: www.example.com\r\nContent-type: text/html\r\n\r\nSome body",
),
+ (
+ Request("http://www.example.com", headers={"Accept": None}),
+ b"GET / HTTP/1.1\r\nHost: www.example.com\r\n\r\n",
+ ),
],
)
def test_request_httprepr(r: Request, expected: bytes) -> None: