Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

[test_downloadermiddleware_httpcache] Adding xfails to impacted tests following hack fix https://github.com/scrapy/scrapy/issues/4085

Royb3df0a84150f
diff --git a/tests/test_downloadermiddleware_httpcache.py b/tests/test_downloadermiddleware_httpcache.py
index eec0feafc..605223088 100644
--- a/tests/test_downloadermiddleware_httpcache.py
+++ b/tests/test_downloadermiddleware_httpcache.py
@@ -6,7 +6,6 @@ import unittest
import email.utils
from contextlib import contextmanager
import pytest
-import sys
from scrapy.http import Response, HtmlResponse, Request
from scrapy.spiders import Spider
@@ -90,6 +89,7 @@ class _BaseTest(unittest.TestCase):
assert any(h in request2.headers for h in (b'If-None-Match', b'If-Modified-Since'))
self.assertEqual(request1.body, request2.body)
+ @pytest.mark.xfail(reason='leveldb not supported in python 3.8')
def test_dont_cache(self):
with self._middleware() as mw:
self.request.meta['dont_cache'] = True
@@ -119,6 +119,7 @@ class DefaultStorageTest(_BaseTest):
time.sleep(2) # wait for cache to expire
assert storage.retrieve_response(self.spider, request2) is None
+ @pytest.mark.xfail(reason='leveldb not supported in python 3.8')
def test_storage_never_expire(self):
with self._storage(HTTPCACHE_EXPIRATION_SECS=0) as storage:
assert storage.retrieve_response(self.spider, self.request) is None
@@ -161,6 +162,8 @@ class LeveldbStorageTest(DefaultStorageTest):
try:
pytest.importorskip('leveldb')
except SystemError:
+ # Happens in python 3.8
+ # This will cause xfail in DefaultStorageTest to trigger
pass
storage_class = 'scrapy.extensions.httpcache.LeveldbCacheStorage'