Scrapy, a fast high-level web crawling & scraping framework for Python.
Engine tests: fix item class spider, add minimal type hints
Eugenio Lacuestab6f77806b0ec
diff --git a/setup.cfg b/setup.cfgindex 89b4ec57e..1fab6fe22 100644--- a/setup.cfg+++ b/setup.cfg@@ -43,9 +43,6 @@ ignore_errors = True[mypy-tests.test_downloader_handlers]ignore_errors = True-[mypy-tests.test_engine]-ignore_errors = True-[mypy-tests.test_exporters]ignore_errors = Truediff --git a/tests/test_engine.py b/tests/test_engine.pyindex ef1204f94..c406d2577 100644--- a/tests/test_engine.py+++ b/tests/test_engine.py@@ -56,7 +56,7 @@ class TestSpider(Spider):name_re = re.compile(r"<h1>(.*?)</h1>", re.M)price_re = re.compile(r">Price: \$(.*?)<", re.M)- item_cls = TestItem+ item_cls: type = TestItemdef parse(self, response):xlink = LinkExtractor()@@ -66,15 +66,15 @@ class TestSpider(Spider):yield Request(url=link.url, callback=self.parse_item)def parse_item(self, response):- item = self.item_cls()+ adapter = ItemAdapter(self.item_cls())m = self.name_re.search(response.text)if m:- item['name'] = m.group(1)- item['url'] = response.url+ adapter['name'] = m.group(1)+ adapter['url'] = response.urlm = self.price_re.search(response.text)if m:- item['price'] = m.group(1)- return item+ adapter['price'] = m.group(1)+ return adapter.itemclass TestDupeFilterSpider(TestSpider):@@ -87,7 +87,7 @@ class DictItemsSpider(TestSpider):class AttrsItemsSpider(TestSpider):- item_class = AttrsItem+ item_cls = AttrsItemtry:@@ -97,14 +97,12 @@ except ImportError:else:TestDataClass = make_dataclass("TestDataClass", [("name", str), ("url", str), ("price", int)])- class DataClassItemsSpider(DictItemsSpider):+ class _dataclass_spider(DictItemsSpider):def parse_item(self, response):item = super().parse_item(response)- return TestDataClass(- name=item.get('name'),- url=item.get('url'),- price=item.get('price'),- )+ return TestDataClass(**item)++ DataClassItemsSpider = _dataclass_spiderclass ItemZeroDivisionErrorSpider(TestSpider):