Scrapy, a fast high-level web crawling & scraping framework for Python.
Update ItemFilter (#5203)
Eugenio Lacuestabcce0660573c
diff --git a/scrapy/extensions/feedexport.py b/scrapy/extensions/feedexport.pyindex 84a79e32d..bd4808e2b 100644--- a/scrapy/extensions/feedexport.py+++ b/scrapy/extensions/feedexport.py@@ -11,6 +11,7 @@ import sysimport warningsfrom datetime import datetimefrom tempfile import NamedTemporaryFile+from typing import Any, Optional, Tuplefrom urllib.parse import unquote, urlparsefrom twisted.internet import defer, threads@@ -54,16 +55,19 @@ class ItemFilter::param feed_options: feed specific options passed from FeedExporter:type feed_options: dict"""+ feed_options: Optional[dict]+ item_classes: Tuple- def __init__(self, feed_options):+ def __init__(self, feed_options: Optional[dict]) -> None:self.feed_options = feed_options- self.item_classes = set()-- if 'item_classes' in self.feed_options:- for item_class in self.feed_options['item_classes']:- self.item_classes.add(load_object(item_class))+ if feed_options is not None:+ self.item_classes = tuple(+ load_object(item_class) for item_class in feed_options.get("item_classes") or ()+ )+ else:+ self.item_classes = tuple()- def accepts(self, item):+ def accepts(self, item: Any) -> bool:"""Return ``True`` if `item` should be exported or ``False`` otherwise.@@ -73,9 +77,8 @@ class ItemFilter::rtype: bool"""if self.item_classes:- return isinstance(item, tuple(self.item_classes))-- return True # accept all items if none declared in item_classes+ return isinstance(item, self.item_classes)+ return True # accept all items by defaultclass IFeedStorage(Interface):