Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Add CrawlerProcess tests for ASYNCIO_ENABLED.

Andrey Rakhmatullinbfb78b8dea44
diff --git a/tests/CrawlerProcess/asyncio_enabled_no_reactor.py b/tests/CrawlerProcess/asyncio_enabled_no_reactor.py
new file mode 100644
index 000000000..dfe028ef4
--- /dev/null
+++ b/tests/CrawlerProcess/asyncio_enabled_no_reactor.py
@@ -0,0 +1,17 @@
+import scrapy
+from scrapy.crawler import CrawlerProcess
+
+
+class NoRequestsSpider(scrapy.Spider):
+ name = 'no_request'
+
+ def start_requests(self):
+ return []
+
+
+process = CrawlerProcess(settings={
+ 'ASYNCIO_ENABLED': True,
+})
+
+process.crawl(NoRequestsSpider)
+process.start()
diff --git a/tests/CrawlerProcess/asyncio_enabled_reactor.py b/tests/CrawlerProcess/asyncio_enabled_reactor.py
new file mode 100644
index 000000000..7a172ea28
--- /dev/null
+++ b/tests/CrawlerProcess/asyncio_enabled_reactor.py
@@ -0,0 +1,22 @@
+import asyncio
+
+from twisted.internet import asyncioreactor
+asyncioreactor.install(asyncio.get_event_loop())
+
+import scrapy
+from scrapy.crawler import CrawlerProcess
+
+
+class NoRequestsSpider(scrapy.Spider):
+ name = 'no_request'
+
+ def start_requests(self):
+ return []
+
+
+process = CrawlerProcess(settings={
+ 'ASYNCIO_ENABLED': True,
+})
+
+process.crawl(NoRequestsSpider)
+process.start()
diff --git a/tests/test_crawler.py b/tests/test_crawler.py
index 05909d995..0b2645280 100644
--- a/tests/test_crawler.py
+++ b/tests/test_crawler.py
@@ -301,3 +301,14 @@ class CrawlerProcessSubprocess(unittest.TestCase):
def test_simple(self):
log = self.run_script('simple.py')
self.assertIn('Spider closed (finished)', log)
+ self.assertNotIn("DEBUG: Asyncio support enabled", log)
+
+ def test_asyncio_enabled_no_reactor(self):
+ log = self.run_script('asyncio_enabled_no_reactor.py')
+ self.assertIn('Spider closed (finished)', log)
+ self.assertIn("DEBUG: Asyncio support enabled", log)
+
+ def test_asyncio_enabled_reactor(self):
+ log = self.run_script('asyncio_enabled_reactor.py')
+ self.assertIn('Spider closed (finished)', log)
+ self.assertIn("DEBUG: Asyncio support enabled", log)