Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Remove obsolete DEPRECATED_SETTINGS (deprecated.py)

nyovc2c6ea376ca2
diff --git a/scrapy/cmdline.py b/scrapy/cmdline.py
index ec78f7c91..a4ec7c8ae 100644
--- a/scrapy/cmdline.py
+++ b/scrapy/cmdline.py
@@ -12,7 +12,6 @@ from scrapy.exceptions import UsageError
from scrapy.utils.misc import walk_modules
from scrapy.utils.project import inside_project, get_project_settings
from scrapy.utils.python import garbage_collect
-from scrapy.settings.deprecated import check_deprecated_settings
def _iter_command_classes(module_name):
@@ -118,7 +117,6 @@ def execute(argv=None, settings=None):
pass
else:
settings['EDITOR'] = editor
- check_deprecated_settings(settings)
inproject = inside_project()
cmds = _get_commands_dict(settings, inproject)
diff --git a/scrapy/settings/deprecated.py b/scrapy/settings/deprecated.py
deleted file mode 100644
index f6f878725..000000000
--- a/scrapy/settings/deprecated.py
+++ /dev/null
@@ -1,23 +0,0 @@
-import warnings
-from scrapy.exceptions import ScrapyDeprecationWarning
-
-DEPRECATED_SETTINGS = [
- ('TRACK_REFS', 'no longer needed (trackref is always enabled)'),
- ('RESPONSE_CLASSES', 'no longer supported'),
- ('DEFAULT_RESPONSE_ENCODING', 'no longer supported'),
- ('BOT_VERSION', 'no longer used (user agent defaults to Scrapy now)'),
- ('ENCODING_ALIASES', 'no longer needed (encoding discovery uses w3lib now)'),
- ('STATS_ENABLED', 'no longer supported (change STATS_CLASS instead)'),
- ('SQLITE_DB', 'no longer supported'),
- ('AUTOTHROTTLE_MIN_DOWNLOAD_DELAY', 'use DOWNLOAD_DELAY instead'),
- ('AUTOTHROTTLE_MAX_CONCURRENCY', 'use CONCURRENT_REQUESTS_PER_DOMAIN instead'),
-]
-
-
-def check_deprecated_settings(settings):
- deprecated = [x for x in DEPRECATED_SETTINGS if settings[x[0]] is not None]
- if deprecated:
- msg = "You are using the following settings which are deprecated or obsolete"
- msg += " (ask [email protected] for alternatives):"
- msg = msg + "\n " + "\n ".join("%s: %s" % x for x in deprecated)
- warnings.warn(msg, ScrapyDeprecationWarning)