Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Fix typing

Iván de Prado Alonsoce445f204624
diff --git a/scrapy/core/engine.py b/scrapy/core/engine.py
index 949d89e76..81a7a5068 100644
--- a/scrapy/core/engine.py
+++ b/scrapy/core/engine.py
@@ -337,8 +337,9 @@ class ExecutionEngine:
if DontCloseSpider in detected_ex:
return None
if self.spider_is_idle():
- reason = detected_ex[CloseSpider].reason if CloseSpider in detected_ex else 'finished'
- self.close_spider(self.spider, reason=reason)
+ ex = detected_ex.get(CloseSpider, CloseSpider(reason='finished'))
+ assert isinstance(ex, CloseSpider) # typing
+ self.close_spider(self.spider, reason=ex.reason)
def close_spider(self, spider: Spider, reason: str = "cancelled") -> Deferred:
"""Close (cancel) spider and clear all its outstanding requests"""