Scrapy, a fast high-level web crawling & scraping framework for Python.
Fix a reactor test on Windows.
Andrey Rakhmatullind4565318c706
diff --git a/tests/CrawlerProcess/twisted_reactor_custom_settings_conflict.py b/tests/CrawlerProcess/twisted_reactor_custom_settings_conflict.pyindex 9a6c01d72..3f219098c 100644--- a/tests/CrawlerProcess/twisted_reactor_custom_settings_conflict.py+++ b/tests/CrawlerProcess/twisted_reactor_custom_settings_conflict.py@@ -2,10 +2,10 @@ import scrapyfrom scrapy.crawler import CrawlerProcess-class PollReactorSpider(scrapy.Spider):- name = 'poll_reactor'+class SelectReactorSpider(scrapy.Spider):+ name = 'select_reactor'custom_settings = {- "TWISTED_REACTOR": "twisted.internet.pollreactor.PollReactor",+ "TWISTED_REACTOR": "twisted.internet.selectreactor.SelectReactor",}@@ -17,6 +17,6 @@ class AsyncioReactorSpider(scrapy.Spider):process = CrawlerProcess()-process.crawl(PollReactorSpider)+process.crawl(SelectReactorSpider)process.crawl(AsyncioReactorSpider)process.start()diff --git a/tests/test_crawler.py b/tests/test_crawler.pyindex d68c50026..e7d5c8132 100644--- a/tests/test_crawler.py+++ b/tests/test_crawler.py@@ -381,8 +381,8 @@ class CrawlerProcessSubprocess(ScriptRunnerMixin, unittest.TestCase):"the asyncio reactor is broken on Windows when running Python ≥ 3.8")def test_reactor_asyncio_custom_settings_conflict(self):log = self.run_script("twisted_reactor_custom_settings_conflict.py")- self.assertIn("Using reactor: twisted.internet.pollreactor.PollReactor", log)- self.assertIn("(twisted.internet.pollreactor.PollReactor) does not match the requested one", log)+ self.assertIn("Using reactor: twisted.internet.selectreactor.SelectReactor", log)+ self.assertIn("(twisted.internet.selectreactor.SelectReactor) does not match the requested one", log)@mark.skipif(sys.implementation.name == 'pypy', reason='uvloop does not support pypy properly')@mark.skipif(platform.system() == 'Windows', reason='uvloop does not support Windows')