Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

bytes_received signal: send spider argument

Eugenio Lacuestadbe20a863ff6
diff --git a/docs/topics/signals.rst b/docs/topics/signals.rst
index 6efb73abb..3e70ca067 100644
--- a/docs/topics/signals.rst
+++ b/docs/topics/signals.rst
@@ -162,7 +162,7 @@ bytes_received
--------------
.. signal:: bytes_received
-.. function:: bytes_received(data, request)
+.. function:: bytes_received(data, request, spider)
Sent by the HTTP 1.1 download handler when a group of bytes is
received for a specific request.
@@ -175,6 +175,9 @@ bytes_received
:param request: the request that generated the response
:type request: :class:`~scrapy.http.Request` object
+ :param spider: the spider associated with the response
+ :type spider: :class:`~scrapy.spiders.Spider` object
+
spider_closed
-------------
diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py
index 92c3d5f5c..c53c9bb2d 100644
--- a/scrapy/core/downloader/handlers/http11.py
+++ b/scrapy/core/downloader/handlers/http11.py
@@ -482,6 +482,7 @@ class _ResponseReader(protocol.Protocol):
signal=signals.bytes_received,
data=bodyBytes,
request=self._request,
+ spider=self._crawler.spider,
)
if self._maxsize and self._bytes_received > self._maxsize:
diff --git a/tests/test_engine.py b/tests/test_engine.py
index c0769c992..57cc89ba3 100644
--- a/tests/test_engine.py
+++ b/tests/test_engine.py
@@ -159,7 +159,7 @@ class CrawlerRun(object):
def item_scraped(self, item, spider, response):
self.itemresp.append((item, response))
- def bytes_received(self, data, request):
+ def bytes_received(self, data, request, spider):
self.bytes[request] += data
def request_scheduled(self, request, spider):