Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Fall back to no-SNi context factory is Twisted<14 is used

Paul Tremberthdcea11a70c52
diff --git a/scrapy/core/downloader/handlers/http11.py b/scrapy/core/downloader/handlers/http11.py
index 4a0612cdf..1634a2a4b 100644
--- a/scrapy/core/downloader/handlers/http11.py
+++ b/scrapy/core/downloader/handlers/http11.py
@@ -122,9 +122,14 @@ class TunnelingTCP4ClientEndpoint(TCP4ClientEndpoint):
"""
self._protocol.dataReceived = self._protocolDataReceived
if TunnelingTCP4ClientEndpoint._responseMatcher.match(bytes):
- # this set proper Server Name Indication extension
- sslOptions = self._contextFactory.creatorForNetloc(
- self._tunneledHost, self._tunneledPort)
+ try:
+ # this sets proper Server Name Indication extension
+ # but is only available for Twisted>=14.0
+ sslOptions = self._contextFactory.creatorForNetloc(
+ self._tunneledHost, self._tunneledPort)
+ except AttributeError:
+ # fall back to non-SNI SSL context factory
+ sslOptions = self._contextFactory
self._protocol.transport.startTLS(sslOptions,
self._protocolFactory)
self._tunnelReadyDeferred.callback(self._protocol)