Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Clean up Twisted version check

Adrián Chavesea851b910e58
diff --git a/tests/test_downloadermiddleware.py b/tests/test_downloadermiddleware.py
index 55af4c240..6168e0176 100644
--- a/tests/test_downloadermiddleware.py
+++ b/tests/test_downloadermiddleware.py
@@ -2,6 +2,7 @@ import asyncio
from unittest import mock, SkipTest
from pytest import mark
+from twisted import version as twisted_version
from twisted.internet import defer
from twisted.internet.defer import Deferred
from twisted.trial.unittest import TestCase
@@ -217,10 +218,9 @@ class MiddlewareUsingCoro(ManagerTestCase):
"""Middlewares using asyncio coroutines should work"""
def test_asyncdef(self):
- import twisted
if (
self.reactor_pytest == 'asyncio'
- and twisted.version < Version('twisted', 18, 4, 0)
+ and twisted_version < Version('twisted', 18, 4, 0)
):
raise SkipTest(
'Due to https://twistedmatrix.com/trac/ticket/9390, this test '
@@ -228,8 +228,6 @@ class MiddlewareUsingCoro(ManagerTestCase):
'18.4.0'
)
- from twisted.python.versions import Version
-
resp = Response('http://example.com/index.html')
class CoroMiddleware: