Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Fix flake8 issues in previously ignored files.

Andrey Rakhmatullineeb199adda2d
diff --git a/.flake8 b/.flake8
index 1c503fb0b..d7aebc24b 100644
--- a/.flake8
+++ b/.flake8
@@ -4,6 +4,8 @@ max-line-length = 119
ignore = W503
exclude =
+ docs/conf.py
+
# Exclude files that are meant to provide top-level imports
# E402: Module level import not at top of file
# F401: Module imported but unused
diff --git a/docs/_ext/scrapydocs.py b/docs/_ext/scrapydocs.py
index 640660943..d02a2e17b 100644
--- a/docs/_ext/scrapydocs.py
+++ b/docs/_ext/scrapydocs.py
@@ -80,24 +80,24 @@ def replace_settingslist_nodes(app, doctree, fromdocname):
def setup(app):
app.add_crossref_type(
- directivename = "setting",
- rolename = "setting",
- indextemplate = "pair: %s; setting",
+ directivename="setting",
+ rolename="setting",
+ indextemplate="pair: %s; setting",
)
app.add_crossref_type(
- directivename = "signal",
- rolename = "signal",
- indextemplate = "pair: %s; signal",
+ directivename="signal",
+ rolename="signal",
+ indextemplate="pair: %s; signal",
)
app.add_crossref_type(
- directivename = "command",
- rolename = "command",
- indextemplate = "pair: %s; command",
+ directivename="command",
+ rolename="command",
+ indextemplate="pair: %s; command",
)
app.add_crossref_type(
- directivename = "reqmeta",
- rolename = "reqmeta",
- indextemplate = "pair: %s; reqmeta",
+ directivename="reqmeta",
+ rolename="reqmeta",
+ indextemplate="pair: %s; reqmeta",
)
app.add_role('source', source_role)
app.add_role('commit', commit_role)
diff --git a/scrapy/utils/testsite.py b/scrapy/utils/testsite.py
index fce77be32..5d3710391 100644
--- a/scrapy/utils/testsite.py
+++ b/scrapy/utils/testsite.py
@@ -23,7 +23,7 @@ class NoMetaRefreshRedirect(util.Redirect):
def render(self, request):
content = util.Redirect.render(self, request)
return content.replace(b'http-equiv=\"refresh\"',
- b'http-no-equiv=\"do-not-refresh-me\"')
+ b'http-no-equiv=\"do-not-refresh-me\"')
def test_site():
diff --git a/tests/CrawlerProcess/asyncio_deferred_signal.py b/tests/CrawlerProcess/asyncio_deferred_signal.py
index bdd3c1fef..b83f6a585 100644
--- a/tests/CrawlerProcess/asyncio_deferred_signal.py
+++ b/tests/CrawlerProcess/asyncio_deferred_signal.py
@@ -5,7 +5,6 @@ from typing import Optional
from scrapy import Spider
from scrapy.crawler import CrawlerProcess
from scrapy.utils.defer import deferred_from_coro
-from twisted.internet.defer import Deferred
class UppercasePipeline:
diff --git a/tests/CrawlerProcess/asyncio_enabled_reactor.py b/tests/CrawlerProcess/asyncio_enabled_reactor.py
index f2a93074b..e561d63c7 100644
--- a/tests/CrawlerProcess/asyncio_enabled_reactor.py
+++ b/tests/CrawlerProcess/asyncio_enabled_reactor.py
@@ -6,8 +6,8 @@ if sys.version_info >= (3, 8) and sys.platform == "win32":
asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy())
asyncioreactor.install(asyncio.get_event_loop())
-import scrapy
-from scrapy.crawler import CrawlerProcess
+import scrapy # noqa: E402
+from scrapy.crawler import CrawlerProcess # noqa: E402
class NoRequestsSpider(scrapy.Spider):
diff --git a/tests/CrawlerProcess/reactor_default.py b/tests/CrawlerProcess/reactor_default.py
index 5a21a3717..2c867df61 100644
--- a/tests/CrawlerProcess/reactor_default.py
+++ b/tests/CrawlerProcess/reactor_default.py
@@ -1,6 +1,6 @@
import scrapy
from scrapy.crawler import CrawlerProcess
-from twisted.internet import reactor
+from twisted.internet import reactor # noqa: F401
class NoRequestsSpider(scrapy.Spider):
@@ -14,4 +14,3 @@ process = CrawlerProcess(settings={})
process.crawl(NoRequestsSpider)
process.start()
-
diff --git a/tests/CrawlerProcess/reactor_default_twisted_reactor_select.py b/tests/CrawlerProcess/reactor_default_twisted_reactor_select.py
index c476722ef..c2b30b044 100644
--- a/tests/CrawlerProcess/reactor_default_twisted_reactor_select.py
+++ b/tests/CrawlerProcess/reactor_default_twisted_reactor_select.py
@@ -1,6 +1,6 @@
import scrapy
from scrapy.crawler import CrawlerProcess
-from twisted.internet import reactor
+from twisted.internet import reactor # noqa: F401
class NoRequestsSpider(scrapy.Spider):
@@ -16,5 +16,3 @@ process = CrawlerProcess(settings={
process.crawl(NoRequestsSpider)
process.start()
-
-
diff --git a/tests/CrawlerProcess/reactor_select.py b/tests/CrawlerProcess/reactor_select.py
index eac6e2f89..ca70c06a0 100644
--- a/tests/CrawlerProcess/reactor_select.py
+++ b/tests/CrawlerProcess/reactor_select.py
@@ -15,5 +15,3 @@ process = CrawlerProcess(settings={})
process.crawl(NoRequestsSpider)
process.start()
-
-
diff --git a/tests/CrawlerProcess/reactor_select_subclass_twisted_reactor_select.py b/tests/CrawlerProcess/reactor_select_subclass_twisted_reactor_select.py
index 47f480605..0035daf1e 100644
--- a/tests/CrawlerProcess/reactor_select_subclass_twisted_reactor_select.py
+++ b/tests/CrawlerProcess/reactor_select_subclass_twisted_reactor_select.py
@@ -25,7 +25,3 @@ process = CrawlerProcess(settings={
process.crawl(NoRequestsSpider)
process.start()
-
-
-
-
diff --git a/tests/CrawlerProcess/reactor_select_twisted_reactor_select.py b/tests/CrawlerProcess/reactor_select_twisted_reactor_select.py
index e0d2dab26..4f8394edb 100644
--- a/tests/CrawlerProcess/reactor_select_twisted_reactor_select.py
+++ b/tests/CrawlerProcess/reactor_select_twisted_reactor_select.py
@@ -17,6 +17,3 @@ process = CrawlerProcess(settings={
process.crawl(NoRequestsSpider)
process.start()
-
-
-