Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Do not cache DNS responses when cache size is 0

Paul Tremberthf0ded6b7759c
diff --git a/scrapy/resolver.py b/scrapy/resolver.py
index 4f4f0b04f..0aaced7e4 100644
--- a/scrapy/resolver.py
+++ b/scrapy/resolver.py
@@ -22,7 +22,8 @@ class CachingThreadedResolver(ThreadedResolver):
# to enforce Scrapy's DNS_TIMEOUT setting's value
timeout = (self.timeout,)
d = super(CachingThreadedResolver, self).getHostByName(name, timeout)
- d.addCallback(self._cache_result, name)
+ if dnscache.limit:
+ d.addCallback(self._cache_result, name)
return d
def _cache_result(self, result, name):