Skip to content

Scrapy, a fast high-level web crawling & scraping framework for Python.

Add typing to scrapy/utils/display.py.

Andrey Rakhmatullinf38cea9c8c54
diff --git a/scrapy/utils/display.py b/scrapy/utils/display.py
index 77c32b002..596cf89e4 100644
--- a/scrapy/utils/display.py
+++ b/scrapy/utils/display.py
@@ -6,17 +6,18 @@ import ctypes
import platform
import sys
from pprint import pformat as pformat_
+from typing import Any
from packaging.version import Version as parse_version
-def _enable_windows_terminal_processing():
+def _enable_windows_terminal_processing() -> bool:
# https://stackoverflow.com/a/36760881
- kernel32 = ctypes.windll.kernel32
+ kernel32 = ctypes.windll.kernel32 # type: ignore[attr-defined]
return bool(kernel32.SetConsoleMode(kernel32.GetStdHandle(-11), 7))
-def _tty_supports_color():
+def _tty_supports_color() -> bool:
if sys.platform != "win32":
return True
@@ -28,7 +29,7 @@ def _tty_supports_color():
return _enable_windows_terminal_processing()
-def _colorize(text, colorize=True):
+def _colorize(text: str, colorize: bool = True) -> str:
if not colorize or not sys.stdout.isatty() or not _tty_supports_color():
return text
try:
@@ -42,9 +43,9 @@ def _colorize(text, colorize=True):
return highlight(text, PythonLexer(), TerminalFormatter())
-def pformat(obj, *args, **kwargs):
+def pformat(obj: Any, *args: Any, **kwargs: Any) -> str:
return _colorize(pformat_(obj), kwargs.pop("colorize", True))
-def pprint(obj, *args, **kwargs):
+def pprint(obj: Any, *args: Any, **kwargs: Any) -> None:
print(pformat(obj, *args, **kwargs))