Display and control your Android device
Fix adb getprop parsing
Romain Vimont2ea12f73db33
diff --git a/app/src/adb/adb.c b/app/src/adb/adb.cindex 5a1ed25d..2fd4b35d 100644--- a/app/src/adb/adb.c+++ b/app/src/adb/adb.c@@ -385,7 +385,7 @@ sc_adb_getprop(struct sc_intr *intr, const char *serial, const char *prop,}char buf[128];- ssize_t r = sc_pipe_read_all_intr(intr, pid, pout, buf, sizeof(buf));+ ssize_t r = sc_pipe_read_all_intr(intr, pid, pout, buf, sizeof(buf) - 1);sc_pipe_close(pout);bool ok = process_check_success_intr(intr, pid, "adb getprop", flags);@@ -397,7 +397,10 @@ sc_adb_getprop(struct sc_intr *intr, const char *serial, const char *prop,return NULL;}- sc_str_truncate(buf, r, " \r\n");+ assert((size_t) r < sizeof(buf));+ buf[r] = '\0';+ size_t len = strcspn(buf, " \r\n");+ buf[len] = '\0';return strdup(buf);}