Skip to content

Display and control your Android device

Filter out non-backward-compatible cameras

Simon Chan2f44da76f476
diff --git a/server/src/main/java/com/genymobile/scrcpy/util/LogUtils.java b/server/src/main/java/com/genymobile/scrcpy/util/LogUtils.java
index 088be7e7..961b8da0 100644
--- a/server/src/main/java/com/genymobile/scrcpy/util/LogUtils.java
+++ b/server/src/main/java/com/genymobile/scrcpy/util/LogUtils.java
@@ -120,6 +120,21 @@ public final class LogUtils {
}
}
+ private static boolean isCameraBackwardCompatible(CameraCharacteristics characteristics) {
+ int[] capabilities = characteristics.get(CameraCharacteristics.REQUEST_AVAILABLE_CAPABILITIES);
+ if (capabilities == null) {
+ return false;
+ }
+
+ for (int capability : capabilities) {
+ if (capability == CameraCharacteristics.REQUEST_AVAILABLE_CAPABILITIES_BACKWARD_COMPATIBLE) {
+ return true;
+ }
+ }
+
+ return false;
+ }
+
public static String buildCameraListMessage(boolean includeSizes) {
StringBuilder builder = new StringBuilder("List of cameras:");
CameraManager cameraManager = ServiceManager.getCameraManager();
@@ -129,9 +144,16 @@ public final class LogUtils {
builder.append("\n (none)");
} else {
for (String id : cameraIds) {
- builder.append("\n --camera-id=").append(id);
CameraCharacteristics characteristics = cameraManager.getCameraCharacteristics(id);
+ if (!isCameraBackwardCompatible(characteristics)) {
+ // Ignore depth cameras as suggested by official documentation
+ // <https://developer.android.com/media/camera/camera2/camera-enumeration>
+ continue;
+ }
+
+ builder.append("\n --camera-id=").append(id);
+
int facing = characteristics.get(CameraCharacteristics.LENS_FACING);
builder.append(" (").append(getCameraFacingName(facing)).append(", ");