Display and control your Android device
Remove MagicNumber checkstyle
Romain Vimont5031b2c8ff42
diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xmlindex 798814d9..812d060b 100644--- a/config/checkstyle/checkstyle.xml+++ b/config/checkstyle/checkstyle.xml@@ -129,11 +129,6 @@ page at http://checkstyle.sourceforge.net/config.html --></module><module name="IllegalInstantiation" /><module name="InnerAssignment" />- <module name="MagicNumber">- <property name="severity" value="info" />- <property name="ignoreHashCodeMethod" value="true" />- <property name="ignoreAnnotation" value="true" />- </module><module name="MissingSwitchDefault" /><module name="SimplifyBooleanExpression" /><module name="SimplifyBooleanReturn" />diff --git a/server/src/main/java/com/genymobile/scrcpy/ControlMessageReader.java b/server/src/main/java/com/genymobile/scrcpy/ControlMessageReader.javaindex e4347ddb..29172c08 100644--- a/server/src/main/java/com/genymobile/scrcpy/ControlMessageReader.java+++ b/server/src/main/java/com/genymobile/scrcpy/ControlMessageReader.java@@ -121,7 +121,6 @@ public class ControlMessageReader {return ControlMessage.createInjectText(text);}- @SuppressWarnings("checkstyle:MagicNumber")private ControlMessage parseInjectTouchEvent() {if (buffer.remaining() < INJECT_TOUCH_EVENT_PAYLOAD_LENGTH) {return null;@@ -171,12 +170,10 @@ public class ControlMessageReader {return new Position(x, y, screenWidth, screenHeight);}- @SuppressWarnings("checkstyle:MagicNumber")private static int toUnsigned(short value) {return value & 0xffff;}- @SuppressWarnings("checkstyle:MagicNumber")private static int toUnsigned(byte value) {return value & 0xff;}diff --git a/server/src/main/java/com/genymobile/scrcpy/Controller.java b/server/src/main/java/com/genymobile/scrcpy/Controller.javaindex dc0fa67b..7595a9d7 100644--- a/server/src/main/java/com/genymobile/scrcpy/Controller.java+++ b/server/src/main/java/com/genymobile/scrcpy/Controller.java@@ -47,7 +47,6 @@ public class Controller {}}- @SuppressWarnings("checkstyle:MagicNumber")public void control() throws IOException {// on start, power on the deviceif (!device.isScreenOn()) {diff --git a/server/src/main/java/com/genymobile/scrcpy/DesktopConnection.java b/server/src/main/java/com/genymobile/scrcpy/DesktopConnection.javaindex a725d83d..0ec43040 100644--- a/server/src/main/java/com/genymobile/scrcpy/DesktopConnection.java+++ b/server/src/main/java/com/genymobile/scrcpy/DesktopConnection.java@@ -84,7 +84,6 @@ public final class DesktopConnection implements Closeable {controlSocket.close();}- @SuppressWarnings("checkstyle:MagicNumber")private void send(String deviceName, int width, int height) throws IOException {byte[] buffer = new byte[DEVICE_NAME_FIELD_LENGTH + 4];diff --git a/server/src/main/java/com/genymobile/scrcpy/DeviceMessageWriter.java b/server/src/main/java/com/genymobile/scrcpy/DeviceMessageWriter.javaindex e2a3a1a2..6c7f3634 100644--- a/server/src/main/java/com/genymobile/scrcpy/DeviceMessageWriter.java+++ b/server/src/main/java/com/genymobile/scrcpy/DeviceMessageWriter.java@@ -13,7 +13,6 @@ public class DeviceMessageWriter {private final byte[] rawBuffer = new byte[MAX_EVENT_SIZE];private final ByteBuffer buffer = ByteBuffer.wrap(rawBuffer);- @SuppressWarnings("checkstyle:MagicNumber")public void writeTo(DeviceMessage msg, OutputStream output) throws IOException {buffer.clear();buffer.put((byte) DeviceMessage.TYPE_CLIPBOARD);diff --git a/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java b/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.javaindex e99084af..d75833f3 100644--- a/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java+++ b/server/src/main/java/com/genymobile/scrcpy/ScreenEncoder.java@@ -145,7 +145,6 @@ public class ScreenEncoder implements Device.RotationListener {return MediaCodec.createEncoderByType("video/avc");}- @SuppressWarnings("checkstyle:MagicNumber")private static MediaFormat createFormat(int bitRate, int maxFps, int iFrameInterval) {MediaFormat format = new MediaFormat();format.setString(MediaFormat.KEY_MIME, "video/avc");diff --git a/server/src/main/java/com/genymobile/scrcpy/ScreenInfo.java b/server/src/main/java/com/genymobile/scrcpy/ScreenInfo.javaindex 0204de82..10acfb50 100644--- a/server/src/main/java/com/genymobile/scrcpy/ScreenInfo.java+++ b/server/src/main/java/com/genymobile/scrcpy/ScreenInfo.java@@ -104,7 +104,6 @@ public final class ScreenInfo {return rect.width() + ":" + rect.height() + ":" + rect.left + ":" + rect.top;}- @SuppressWarnings("checkstyle:MagicNumber")private static Size computeVideoSize(int w, int h, int maxSize) {// Compute the video size and the padding of the content inside this video.// Principle:diff --git a/server/src/main/java/com/genymobile/scrcpy/Server.java b/server/src/main/java/com/genymobile/scrcpy/Server.javaindex db093053..c4954429 100644--- a/server/src/main/java/com/genymobile/scrcpy/Server.java+++ b/server/src/main/java/com/genymobile/scrcpy/Server.java@@ -69,7 +69,6 @@ public final class Server {}).start();}- @SuppressWarnings("checkstyle:MagicNumber")private static Options createOptions(String... args) {if (args.length < 1) {throw new IllegalArgumentException("Missing client version");@@ -115,7 +114,6 @@ public final class Server {return options;}- @SuppressWarnings("checkstyle:MagicNumber")private static Rect parseCrop(String crop) {if ("-".equals(crop)) {return null;@@ -140,7 +138,6 @@ public final class Server {}}- @SuppressWarnings("checkstyle:MagicNumber")private static void suggestFix(Throwable e) {if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {if (e instanceof MediaCodec.CodecException) {diff --git a/server/src/main/java/com/genymobile/scrcpy/StringUtils.java b/server/src/main/java/com/genymobile/scrcpy/StringUtils.javaindex 199fc8c1..dac05466 100644--- a/server/src/main/java/com/genymobile/scrcpy/StringUtils.java+++ b/server/src/main/java/com/genymobile/scrcpy/StringUtils.java@@ -5,7 +5,6 @@ public final class StringUtils {// not instantiable}- @SuppressWarnings("checkstyle:MagicNumber")public static int getUtf8TruncationIndex(byte[] utf8, int maxLength) {int len = utf8.length;if (len <= maxLength) {diff --git a/server/src/test/java/com/genymobile/scrcpy/ControlMessageReaderTest.java b/server/src/test/java/com/genymobile/scrcpy/ControlMessageReaderTest.javaindex 2f95dfe1..1905942b 100644--- a/server/src/test/java/com/genymobile/scrcpy/ControlMessageReaderTest.java+++ b/server/src/test/java/com/genymobile/scrcpy/ControlMessageReaderTest.java@@ -80,7 +80,6 @@ public class ControlMessageReaderTest {}@Test- @SuppressWarnings("checkstyle:MagicNumber")public void testParseTouchEvent() throws IOException {ControlMessageReader reader = new ControlMessageReader();@@ -116,7 +115,6 @@ public class ControlMessageReaderTest {}@Test- @SuppressWarnings("checkstyle:MagicNumber")public void testParseScrollEvent() throws IOException {ControlMessageReader reader = new ControlMessageReader();diff --git a/server/src/test/java/com/genymobile/scrcpy/StringUtilsTest.java b/server/src/test/java/com/genymobile/scrcpy/StringUtilsTest.javaindex 7d89ee64..89799c5e 100644--- a/server/src/test/java/com/genymobile/scrcpy/StringUtilsTest.java+++ b/server/src/test/java/com/genymobile/scrcpy/StringUtilsTest.java@@ -8,7 +8,6 @@ import java.nio.charset.StandardCharsets;public class StringUtilsTest {@Test- @SuppressWarnings("checkstyle:MagicNumber")public void testUtf8Truncate() {String s = "aÉbÔc";byte[] utf8 = s.getBytes(StandardCharsets.UTF_8);