Skip to content

YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context

fix(ci): fail closed when hashing signed payloads

Ezra Ellette01c1d642986c
diff --git a/.github/actions/setup-persistent-windows-cache/action.yml b/.github/actions/setup-persistent-windows-cache/action.yml
index 93308acc3..de7fdbfec 100644
--- a/.github/actions/setup-persistent-windows-cache/action.yml
+++ b/.github/actions/setup-persistent-windows-cache/action.yml
@@ -43,7 +43,7 @@ runs:
"$cacheRoot\native-deps",
$persistentTarget,
"$cacheRoot\tauri-v2\$env:SCREENPIPE_RELEASE_FLAVOR\$env:SCREENPIPE_RELEASE_TARGET",
- "$cacheRoot\signed-binaries-v1"
+ "$cacheRoot\signed-binaries-v2"
) | ForEach-Object { New-Item -ItemType Directory -Force -Path $_ | Out-Null }
# Bundle output is release-specific. Compiler outputs and downloads stay warm.
@@ -76,7 +76,7 @@ runs:
'RUSTC_WRAPPER=sccache',
"BUN_INSTALL_CACHE_DIR=$cacheRoot\bun",
"SCREENPIPE_NATIVE_CACHE_DIR=$cacheRoot\native-deps",
- "SCREENPIPE_SIGNED_BINARY_CACHE_DIR=$cacheRoot\signed-binaries-v1"
+ "SCREENPIPE_SIGNED_BINARY_CACHE_DIR=$cacheRoot\signed-binaries-v2"
) | Out-File -FilePath $env:GITHUB_ENV -Encoding utf8 -Append
"$cacheRoot\cargo\bin" | Out-File -FilePath $env:GITHUB_PATH -Encoding utf8 -Append
diff --git a/apps/screenpipe-app-tauri/src-tauri/sign-ssl.ps1 b/apps/screenpipe-app-tauri/src-tauri/sign-ssl.ps1
index b74896ae8..99a0b4096 100644
--- a/apps/screenpipe-app-tauri/src-tauri/sign-ssl.ps1
+++ b/apps/screenpipe-app-tauri/src-tauri/sign-ssl.ps1
@@ -12,6 +12,8 @@ param(
[string]$FilePath
)
+$ErrorActionPreference = 'Stop'
+
# Skip if credentials aren't set (local dev builds)
if (-not $env:ESIGNER_USERNAME -or -not $env:ESIGNER_PASSWORD) {
Write-Host "Skipping code signing (no credentials): $FilePath"
@@ -111,7 +113,14 @@ $originalFilePath = $FilePath
$signatureCacheFile = $null
if ($env:SCREENPIPE_SIGNED_BINARY_CACHE_DIR -and $env:ESIGNER_CREDENTIAL_ID) {
New-Item -ItemType Directory -Force -Path $env:SCREENPIPE_SIGNED_BINARY_CACHE_DIR | Out-Null
- $unsignedHash = (Get-FileHash -LiteralPath $originalFilePath -Algorithm SHA256).Hash.ToLowerInvariant()
+ $fileHashAlgorithm = [System.Security.Cryptography.SHA256]::Create()
+ $fileStream = [System.IO.File]::OpenRead($originalFilePath)
+ try {
+ $unsignedHash = ([BitConverter]::ToString($fileHashAlgorithm.ComputeHash($fileStream))).Replace('-', '').ToLowerInvariant()
+ } finally {
+ $fileStream.Dispose()
+ $fileHashAlgorithm.Dispose()
+ }
$cacheIdentity = "v1|$env:ESIGNER_CREDENTIAL_ID|$unsignedHash"
$sha256 = [System.Security.Cryptography.SHA256]::Create()
try {