YC (S26) | Open Computer History | Continuously record your company computer work, map your workflows, help you find work worth automating, and power your agents' context
Rust agentsagiaiai-memoryaudio-recordingcomputer-visionhermeshermes-agentllmlocal-ailocal-firstmachine-learningmcpmultimodalopenclawprivacyrewindscreen-recordingspeech-to-textycombinator
fix(workflows): offer sharing consent on workspace entry (#7376)
Louis Beaumont05b3f08ae157
diff --git a/apps/screenpipe-app-tauri/components/workflows/workflow-tasks-prompt.test.tsx b/apps/screenpipe-app-tauri/components/workflows/workflow-tasks-prompt.test.tsxindex feb837a20..a50cd55cc 100644--- a/apps/screenpipe-app-tauri/components/workflows/workflow-tasks-prompt.test.tsx+++ b/apps/screenpipe-app-tauri/components/workflows/workflow-tasks-prompt.test.tsx@@ -22,13 +22,14 @@ function service(states = [false, false, false, false]) {};}const toggle = () => screen.getByRole("switch", { name: "Automatic updates" });-async function loaded() { await waitFor(() => expect(toggle()).toBeEnabled()); }+async function loaded() { await waitFor(() => expect(document.querySelector("[aria-label=\"Automatic updates\"]")).toBeEnabled()); }async function enable() {fireEvent.click(toggle());fireEvent.click(await screen.findByRole("button", { name: "Enable automatic updates" }));}describe("workflow schedule control", () => {- it("does not load or mutate while Chat is active", () => {+ it("does not load, prompt, or mutate while Chat is active", () => {+ f.settings.workflowSharingPromptSeen = {};const tasks = service(); render(<WorkflowTasksPrompt active={false} tasks={tasks} />);expect(tasks.load).not.toHaveBeenCalled(); expect(tasks.enable).not.toHaveBeenCalled();expect(screen.queryByRole("switch")).not.toBeInTheDocument();@@ -77,14 +78,17 @@ describe("workflow schedule control", () => {await waitFor(() => expect(tasks.disable).toHaveBeenCalledTimes(2));await waitFor(() => expect(screen.getByRole("status")).toBeEmptyDOMElement()); expect(tasks.enable).not.toHaveBeenCalled();});- it("shows enable failure in the consent dialog and offers sharing only after success", async () => {+ it("shows enable failures after the independent sharing choice", async () => {f.settings.workflowSharingPromptSeen = {};const tasks = service(); tasks.enable.mockRejectedValueOnce(new Error("offline"));- render(<WorkflowTasksPrompt active tasks={tasks} />); await loaded(); await enable();+ render(<WorkflowTasksPrompt active tasks={tasks} />); await loaded();+ fireEvent.click(await screen.findByText("Skip sharing"));+ await enable();expect(await screen.findByRole("alert")).toHaveTextContent("Could not enable");expect(screen.queryByText("Skip sharing")).not.toBeInTheDocument();fireEvent.click(screen.getByRole("button", {name:"Enable automatic updates"}));- expect(await screen.findByText("Skip sharing")).toBeVisible();+ await waitFor(() => expect(screen.queryByRole("dialog")).not.toBeInTheDocument());+ expect(toggle()).toBeChecked();});it("preserves account-scoped sharing consent separately from the schedules", async () => {f.settings.workflowSharingPromptSeen = {"another-account":"2026-09-23"};@@ -97,7 +101,7 @@ describe("workflow schedule control", () => {f.settings.workflowSharingPromptSeen = {};const tasks = service();const view = render(<WorkflowTasksPrompt active tasks={tasks} />);- await loaded(); await enable();+ await loaded();expect(await screen.findByRole("dialog", { name: "Help improve Screenpipe" })).toBeVisible();view.rerender(<WorkflowTasksPrompt active backendReady={false} tasks={tasks} />);expect(screen.getByRole("dialog", { name: "Help improve Screenpipe" })).toBeVisible();@@ -107,21 +111,58 @@ describe("workflow schedule control", () => {await waitFor(() => expect(screen.queryByRole("dialog")).not.toBeInTheDocument());expect(f.settings.workflowSharingPromptSeen["fixture-user"]).toBe("2026-09-23");});- it("ignores outside clicks on both consent steps without recording a choice", async () => {+ it("ignores outside clicks on sharing and schedule confirmation without recording a choice", async () => {f.settings.workflowSharingPromptSeen = {};const tasks = service(); render(<WorkflowTasksPrompt active tasks={tasks} />); await loaded();- fireEvent.click(toggle());- // Radix registers outside-pointer handling after the opening event.+ await screen.findByRole("dialog", { name: "Help improve Screenpipe" });await act(async () => { await new Promise(resolve => setTimeout(resolve, 0)); });fireEvent.pointerDown(document.querySelector("[data-modal-overlay]")!, { pointerType: "mouse", button: 0 });- expect(screen.getByRole("dialog", { name: "Keep your workflows up to date?" })).toBeVisible();- fireEvent.click(screen.getByRole("button", { name: "Enable automatic updates" }));- expect(await screen.findByText("Skip sharing")).toBeVisible();- fireEvent.pointerDown(document.querySelector("[data-modal-overlay]")!, { pointerType: "mouse", button: 0 });expect(screen.getByRole("dialog", { name: "Help improve Screenpipe" })).toBeVisible();expect(f.update).not.toHaveBeenCalled();fireEvent.keyDown(screen.getByRole("dialog"), { key: "Escape" });await waitFor(() => expect(screen.queryByRole("dialog")).not.toBeInTheDocument());+ fireEvent.click(toggle());+ await act(async () => { await new Promise(resolve => setTimeout(resolve, 0)); });+ fireEvent.pointerDown(document.querySelector("[data-modal-overlay]")!, { pointerType: "mouse", button: 0 });+ expect(screen.getByRole("dialog", { name: "Keep your workflows up to date?" })).toBeVisible();+ expect(tasks.enable).not.toHaveBeenCalled();+ });+ it("offers sharing on first entry with updates off, without enabling or granting anything", async () => {+ f.settings.workflowSharingPromptSeen = {};+ const tasks = service();+ const view = render(<WorkflowTasksPrompt active tasks={tasks} />);+ expect(await screen.findByRole("dialog", { name: "Help improve Screenpipe" })).toBeVisible();+ expect(tasks.enable).not.toHaveBeenCalled(); expect(f.update).not.toHaveBeenCalled();+ fireEvent.click(screen.getByText("Skip sharing"));+ await loaded(); expect(toggle()).not.toBeChecked();+ expect(f.update).toHaveBeenCalledWith({ workflowSharingPromptSeen: { "fixture-user": "2026-09-23" } });+ view.rerender(<WorkflowTasksPrompt active={false} tasks={tasks} />);+ view.rerender(<WorkflowTasksPrompt active tasks={tasks} />); await loaded();+ expect(screen.queryByRole("dialog")).not.toBeInTheDocument();+ await enable(); await waitFor(() => expect(toggle()).toBeChecked());+ expect(screen.queryByRole("dialog")).not.toBeInTheDocument();+ });+ it("offers sharing before the recorder or automatic-update access is ready", async () => {+ f.settings.workflowSharingPromptSeen = {};+ const tasks = service();+ render(<WorkflowTasksPrompt active backendReady={false} canEnable={false} tasks={tasks} />);+ expect(await screen.findByRole("dialog", { name: "Help improve Screenpipe" })).toBeVisible();+ expect(tasks.load).not.toHaveBeenCalled(); expect(tasks.enable).not.toHaveBeenCalled();+ });+ it("waits for an account and keeps each account's prompt choice separate", async () => {+ f.settings.user = null; f.settings.workflowSharingPromptSeen = {};+ const tasks = service(); const view = render(<WorkflowTasksPrompt active tasks={tasks} />);+ await loaded(); expect(screen.queryByRole("dialog")).not.toBeInTheDocument();+ f.settings.user = { id: "first-account" };+ view.rerender(<WorkflowTasksPrompt active tasks={tasks} />);+ fireEvent.click(await screen.findByText("Skip sharing"));+ f.settings.user = { id: "second-account" };+ view.rerender(<WorkflowTasksPrompt active tasks={tasks} />);+ expect(await screen.findByText("Skip sharing")).toBeVisible();+ expect(f.settings.workflowSharingPromptSeen).toEqual({ "first-account": "2026-09-23" });+ f.settings.user = null;+ view.rerender(<WorkflowTasksPrompt active tasks={tasks} />);+ expect(screen.queryByRole("dialog")).not.toBeInTheDocument();});it("waits for backend readiness and recovers on reconnect without clicking retry", async () => {const tasks = service([true,true,true,true]);diff --git a/apps/screenpipe-app-tauri/components/workflows/workflow-tasks-prompt.tsx b/apps/screenpipe-app-tauri/components/workflows/workflow-tasks-prompt.tsxindex d1356fa5b..8550e6a18 100644--- a/apps/screenpipe-app-tauri/components/workflows/workflow-tasks-prompt.tsx+++ b/apps/screenpipe-app-tauri/components/workflows/workflow-tasks-prompt.tsx@@ -47,12 +47,18 @@ export function WorkflowTasksPrompt({ active, tasks = desktopTasks, backendReadyif (account) void updateSettings({ workflowSharingPromptSeen: { ...current.current.workflowSharingPromptSeen, [account]: SHARING_NOTICE_VERSION } }).catch(() => {});setOpen(false);}, [updateSettings]);- function nextStep() {+ // Sharing is an optional Workflows choice, independent of scheduled discovery.+ // Account hydration and workspace entry can happen before the recorder is ready.+ useEffect(() => {const value = current.current;- if (value.user?.id && value.workflowSharingPromptSeen?.[value.user.id] !== SHARING_NOTICE_VERSION) {- setError(""); setStep("sharing");- } else setOpen(false);- }+ const account = value.user?.id;+ setOpen(false);+ setStep("tasks");+ if (active && account && value.workflowSharingPromptSeen?.[account] !== SHARING_NOTICE_VERSION) {+ setStep("sharing");+ setOpen(true);+ }+ }, [active, settings.user?.id]);useEffect(() => { if (open) title.current?.focus(); }, [step, open]);// Read again on reconnection, returning from Chat, and external task changes.@@ -62,9 +68,6 @@ export function WorkflowTasksPrompt({ active, tasks = desktopTasks, backendReadylet loading = false;let timer: ReturnType<typeof setTimeout> | undefined;let attempts = 0;- let offeredSharing = false;- // Recorder reconnects refresh task status, not an open consent decision.- if (!active) { setOpen(false); setStep("tasks"); }setSetup(null);setError("");async function load() {@@ -82,12 +85,6 @@ export function WorkflowTasksPrompt({ active, tasks = desktopTasks, backendReadysetFailedTarget(null);}attempts = 0;- const account = current.current.user?.id;- if (!offeredSharing && value.enabled && account && current.current.workflowSharingPromptSeen?.[account] !== SHARING_NOTICE_VERSION) {- offeredSharing = true;- setStep("sharing");- setOpen(true);- }} catch {if (cancelled || enabling.current || startedRevision !== revision.current) return;setSetup(null);@@ -125,7 +122,7 @@ export function WorkflowTasksPrompt({ active, tasks = desktopTasks, backendReadyif (enabled ? !confirmed.enabled : confirmed.tasks?.some(task => task.enabled) || confirmed.enabled) {throw new Error("Some task settings did not change.");}- if (enabled) nextStep();+ if (enabled) setOpen(false);} catch {// A partial write is not success. Re-read the actual group, never make an// optimistic all-on/all-off claim or roll a user's off request back on.@@ -176,7 +173,7 @@ export function WorkflowTasksPrompt({ active, tasks = desktopTasks, backendReady{step === "tasks" ? "Discover workflows and keep them accurate with automatic updates." : "Share new Workflows chats to improve workflows and train Screenpipe’s own AI models. Never external providers’ models."}</DialogDescription></DialogHeader>- {step === "sharing" ? <WorkflowSharingControls compact onDone={finishSharing} onBusyChange={setBusy} /> : <>+ {step === "sharing" ? <WorkflowSharingControls key={settings.user?.id} compact onDone={finishSharing} onBusyChange={setBusy} /> : <>{setup && <div className="flex items-center gap-3 rounded-lg border p-4"><Clock3 className="h-4 w-4 shrink-0 text-muted-foreground" aria-hidden="true" /><div className="min-w-0"><p className="text-sm font-medium">{setup.title}</p><p className="text-xs text-muted-foreground">{setup.schedule} · While Screenpipe is open</p></div>@@ -188,7 +185,7 @@ export function WorkflowTasksPrompt({ active, tasks = desktopTasks, backendReady</details>{error && <p role="alert" className="text-sm text-destructive">{error}</p>}<DialogFooter className="gap-2 sm:gap-0">- <Button variant="outline" disabled={busy} onClick={nextStep}>Not now</Button>+ <Button variant="outline" disabled={busy} onClick={() => setOpen(false)}>Not now</Button><Button disabled={busy || !setup} onClick={() => void save(true)}>{busy && <Loader2 className="mr-2 h-4 w-4 animate-spin" aria-hidden="true" />} {busy ? ui("Enabling…") : ui("Enable automatic updates")}</Button></DialogFooter></>}